Skip to Content

Contributors

Best practice add optional="show" when adding fields in tree views

Hello Contributors!

 

I love to have your opinions here.

 

I would recommend to PSC to review when migrating modules to ask authors for adding -> optional="show" <- to the fields they add. In order to be possible to hide.

 

This is our sale-workflow runbot talking about sale order lines (NOTE: in v16!! In v15 is simply impossible to test anything without uninstalling 12-15 modules to have something we can call “VIEW” 😃 )

 

 

This is the best we could have.

 

 

Fields that cannot be hidden:

 

  • Sequence2
  • Lot_id
  • Elaborations_ids
  • Elaboration_note

 

This best practice could apply to sale.order.lines, and all the lines in general, lis invoice lines, stock picking lines, etc…

 

Has it any sense for you?

 

Best regards,

Rafael Blasco

Moduon Team

 


by Rafael Blasco (Moduon) - 06:50 - 28 Aug 2023

Follow-Ups

  • Re: Best practice add optional="show" when adding fields in tree views
    I also agree with the request from a functional standpoint: especially in big repos like sale-workflow, there should be a specific attention on:

    - preserving ux of runboat 

    allowing to hide non-required fields in list views is particularly useful in this regard, eg. sale order lines 

    - avoiding publishing modules disrupting base functional testing (eg: confirming an order, creating an invoice...)

    This can be achieved by adding settings enabling the "intrusive" behavior, by not using standard records such as "Azure interior" for testing but creating a specifically named record, and in general by trying to leave runboat as it was found on a functional level :)

    My 2 cents!

    Francesco

    Il giorno mar 29 ago 2023 alle ore 11:01 Ronald Portier <notifications@odoo-community.org> ha scritto:
    Thanks Pedro, we are in complete agreement then.
    
    
    Regards, Ronald
    
    
    Op 29-08-2023 om 10:42 schreef Pedro M. Baeza:
    
    
    > Sorry, my bad. I don't know why, I read optional="hide". It's OK to 
    
    
    > put optional="show", but I would leave out of the equation mandatory 
    
    
    > fields without default, or those protected with a group, as the group 
    
    
    > is already the filtering method for not showing them.
    
    
    >
    
    
    > Regards.
    
    
    >
    
    
    > _______________________________________________
    
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15 
    
    
    > <https://odoo-community.org/groups/contributors-15>
    
    
    > Post to: mailto:contributors@odoo-community.org
    
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe 
    
    
    > <https://odoo-community.org/groups?unsubscribe>
    
    
    >
    

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe



    --

    Francesco Foresti
    Sicurpharma Srl
    +39 333 8123 790

    by Francesco Foresti - 06:21 - 14 Sep 2023
  • Re: Best practice add optional="show" when adding fields in tree views
    Thanks Pedro, we are in complete agreement then.
    
    
    Regards, Ronald
    
    
    Op 29-08-2023 om 10:42 schreef Pedro M. Baeza:
    
    > Sorry, my bad. I don't know why, I read optional="hide". It's OK to 
    
    > put optional="show", but I would leave out of the equation mandatory 
    
    > fields without default, or those protected with a group, as the group 
    
    > is already the filtering method for not showing them.
    
    >
    
    > Regards.
    
    >
    
    > _______________________________________________
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15 
    
    > <https://odoo-community.org/groups/contributors-15>
    
    > Post to: mailto:contributors@odoo-community.org
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe 
    
    > <https://odoo-community.org/groups?unsubscribe>
    
    >
    

    by "Ronald Portier" <rportier@therp.nl> - 11:01 - 29 Aug 2023
  • Re: Best practice add optional="show" when adding fields in tree views
    Sorry, my bad. I don't know why, I read optional="hide". It's OK to put optional="show", but I would leave out of the equation mandatory fields without default, or those protected with a group, as the group is already the filtering method for not showing them.

    Regards.

    by Pedro M. Baeza - 10:41 - 29 Aug 2023
  • Re: Best practice add optional="show" when adding fields in tree views
    Hi Pedro,
    
    
    Maybe it is me, but I am missing the point of what you are saying. On 
    the one hand you are saying the proposed practice of making extra fields 
    in a tree view is not a good practice, but then you say the needed extra 
    fields need to be optional="show" or not optional.
    
    
    In general I think using optional="show" for newly added fields is a 
    good practice, unless there are reasons in a feature/module that demand 
    the field always visible even in the tree view.
    
    
    So maybe you can expand a bit of what you where saying, as I am open to 
    the arguments.
    
    
    Kind regards, Ronald
    
    
    Op 29-08-2023 om 09:36 schreef Pedro M. Baeza:
    
    > It's not a good practice, as when you install a module that is adding 
    
    > a feature, such a feature may require extra fields for its definition, 
    
    > so they need to be optional="show" or directly not optional from the 
    
    > moment you install it. On runbot, as all modules are installed, you 
    
    > have a lot of columns, but it's the price to pay for having this 
    
    > automated build system.
    
    >
    
    > Regards.
    
    >
    
    > _______________________________________________
    
    > Mailing-List: https://odoo-community.org/groups/contributors-15 
    
    > <https://odoo-community.org/groups/contributors-15>
    
    > Post to: mailto:contributors@odoo-community.org
    
    > Unsubscribe: https://odoo-community.org/groups?unsubscribe 
    
    > <https://odoo-community.org/groups?unsubscribe>
    
    >
    

    by "Ronald Portier" <rportier@therp.nl> - 10:26 - 29 Aug 2023
  • Re: Best practice add optional="show" when adding fields in tree views
    It's not a good practice, as when you install a module that is adding a feature, such a feature may require extra fields for its definition, so they need to be optional="show" or directly not optional from the moment you install it. On runbot, as all modules are installed, you have a lot of columns, but it's the price to pay for having this automated build system.

    Regards.

    by Pedro M. Baeza - 09:36 - 29 Aug 2023