Contributors

Hi,

first of all thank you for your effort. New contrinutors are always welcome. We all know the learning curve is quite steep from beginning but try to help.

I did quick review of your blog post. Few suggestions:

*) Update the formatting to make it more readable. After the first paragraph the font gets quite small and colors hard to see:

*) There is no need in my opinion to repeat contents of the links that ar provided. Rather focus on things that were not so obvious (if any) from the instructions.

*) "(7)    After pushing changes to your copy of the original repository on GitHub, compare your version ..." - you're describing standard PR functionality of GitHub. It would be better to say so.

*) "After that you can send an email on OCA mailing list, and you can ask if someone is ready to review your upgraded module and make testing on it." This actually is not really the way most modules are migrated - people usually do not announce their PR in mailing list. Instead they may mention (through @ in comments) the maintainer(s) of the module/repository to draw their attention.

*) One more think you could have done (and is a good practice) is mentioning your PR in the comments of "Migration to version XX.0"  - in your case https://github.com/OCA/product-attribute/issues/1446

One more thing you may decide to include into your article and/or realize yourself: In your email you mention "you succeeded after a huge effort" and your "successful pull request". So far you have succeeded partially only - your PR passes required automated tests which is absolute necessity for it to be considered worth merging. You do not yet have enough approvals (you actually have none so far) and the required time limit has not been reached after that. I can't quickly find the document that describes this. Only after you gather enough (2 I think) approvals and that time limit passes the PR can be merged and considered successfull.

So I'd suggest working the additional steps till you reach the end of the process for your blog post (and first migration) to be complete.

Best luck and regards

    Radovan Skolnik

On utorok 13. augusta 2024 16:17:08 CEST mohamed alkobrosly wrote:

> Here is my experience with my first contribution to OCA:

> https://blog.kobros-tech.com/2024/08/highlights-on-my-contributions-to-odoo

> .html [1] I hope it will be useful to the new contributors.

> Thanks all,

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 [2]

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe [3]

>

>

>

> [1]

> https://blog.kobros-tech.com/2024/08/highlights-on-my-contributions-to-odoo

> .html [2] https://odoo-community.org/groups/contributors-15

> [3] https://odoo-community.org/groups?unsubscribe

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

Hi,

first of all thank you for your effort. New contrinutors are always welcome. We all know the learning curve is quite steep from beginning but try to help.

I did quick review of your blog post. Few suggestions:

*) Update the formatting to make it more readable. After the first paragraph the font gets quite small and colors hard to see:

*) There is no need in my opinion to repeat contents of the links that ar provided. Rather focus on things that were not so obvious (if any) from the instructions.

*) "(7)    After pushing changes to your copy of the original repository on GitHub, compare your version ..." - you're describing standard PR functionality of GitHub. It would be better to say so.

*) "After that you can send an email on OCA mailing list, and you can ask if someone is ready to review your upgraded module and make testing on it." This actually is not really the way most modules are migrated - people usually do not announce their PR in mailing list. Instead they may mention (through @ in comments) the maintainer(s) of the module/repository to draw their attention.

*) One more think you could have done (and is a good practice) is mentioning your PR in the comments of "Migration to version XX.0"  - in your case https://github.com/OCA/product-attribute/issues/1446

One more thing you may decide to include into your article and/or realize yourself: In your email you mention "you succeeded after a huge effort" and your "successful pull request". So far you have succeeded partially only - your PR passes required automated tests which is absolute necessity for it to be considered worth merging. You do not yet have enough approvals (you actually have none so far) and the required time limit has not been reached after that. I can't quickly find the document that describes this. Only after you gather enough (2 I think) approvals and that time limit passes the PR can be merged and considered successfull.

So I'd suggest working the additional steps till you reach the end of the process for your blog post (and first migration) to be complete.

Best luck and regards

    Radovan Skolnik

On utorok 13. augusta 2024 16:17:08 CEST mohamed alkobrosly wrote:

> Here is my experience with my first contribution to OCA:

> https://blog.kobros-tech.com/2024/08/highlights-on-my-contributions-to-odoo

> .html [1] I hope it will be useful to the new contributors.

> Thanks all,

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 [2]

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe [3]

>

>

>

> [1]

> https://blog.kobros-tech.com/2024/08/highlights-on-my-contributions-to-odoo

> .html [2] https://odoo-community.org/groups/contributors-15

> [3] https://odoo-community.org/groups?unsubscribe