Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Info on "lost" PR

Archives

Contributors

Re: Add v 12.0 to Fleet

Re: Info on "lost" PR

Info on "lost" PR

Hi Daniel,
sorry if I write directly to you, but I need help to understand the right path to complete the PR.
Some time ago you approved one of my PR https://github.com/OCA/management-system/pull/265 (my first on OCA ;-)), but I have other that are waiting:
264, 266, 267, 282, 283, 284, 286 and the porting of 265: 325 and 326.
There is some procedure to request revisions or your team do it based on community necessity/priority?
Some hint?

Thanks in advance

Stefano Consolaro
www.mymage.it
by Stefano Consolaro - 12:31 - 2 Jun 2020

Reference

  • Add v 12.0 to Fleet
    Hi,
    in https://github.com/OCA/fleet I see only v.13 branch.
    It is possible to have v.12 too?
    I have a micro module to propose.
    Thanks

    Stefano Consolaro
    www.mymage.it
    by Stefano Consolaro - 11:20 - 31 May 2020

    6 replies 6 replies

    • Re: Info on "lost" PR
      I like "make reviews to get reviewers", the domino effect can have a good result in this case.
      My only problem is to learn (Odoo, code, ...) do to useful review, but I will do.
      Thanks
      Stefano

      Da: "Daniel Reis" dreis@opensourceintegrators.com
      Hi Stefan, not a procedure, more like a social skill :-)
      I usually try tagging/pinging people to help, but that’s not always successful.
      Next you can look for other pending PRs and do review them. That “entitles” you to ask the person to review back your PR.
      This is not because of you or what you’re doing. It happens to me also. The thing is we have more PR proponents that PR reviewers. The solution, IMO, is to make reviews to get reviewers.
      Thanks
      Daniel

      Da: "Stefano Consolaro" stefano.consolaro@mymage.it
      Hi Daniel,
      sorry if I write directly to you, but I need help to understand the right path to complete the PR.
      Some time ago you approved one of my PR https://github.com/OCA/management-system/pull/265 (my first on OCA ;-)), but I have other that are waiting:
      264, 266, 267, 282, 283, 284, 286 and the porting of 265: 325 and 326.
      There is some procedure to request revisions or your team do it based on community necessity/priority?
      Some hint?

      Thanks in advance


      by Stefano Consolaro - 11:35 - 2 Jun 2020
    • Re: Info on "lost" PR
      Hi Stefan, not a procedure, more like a social skill :-)

      I usually try tagging/pinging people to help, but that’s not always successful.

      Next you can look for other pending PRs and do review them. That “entitles” you to ask the person to review back your PR.

      This is not because of you or what you’re doing. It happens to me also. The thing is we have more PR proponents that PR reviewers. The solution, IMO, is to make reviews to get reviewers.

      Thanks
      Daniel

      Stefano Consolaro <stefano.consolaro@mymage.it> escreveu em seg, 1/06/2020 às 23:33 :
      Well done, I used the list address :-(
      Remember to not do some things after midnight.


      Da: "Stefano Consolaro" stefano.consolaro@mymage.it
      Cc:
      Data: Tue, 2 Jun 2020 00:26:07 +0200
      Oggetto: Info on "lost" PR

      Hi Daniel,
      sorry if I write directly to you, but I need help to understand the right path to complete the PR.
      Some time ago you approved one of my PR https://github.com/OCA/management-system/pull/265 (my first on OCA ;-)), but I have other that are waiting:
      264, 266, 267, 282, 283, 284, 286 and the porting of 265: 325 and 326.
      There is some procedure to request revisions or your team do it based on community necessity/priority?
      Some hint?

      Thanks in advance

      Stefano Consolaro


      Stefano Consolaro

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      --
      Thanks
      Daniel
      by Daniel Reis - 12:45 - 2 Jun 2020
    • Re: Info on "lost" PR
      Well done, I used the list address :-(
      Remember to not do some things after midnight.


      Da: "Stefano Consolaro" stefano.consolaro@mymage.it
      A: contributors@odoo-community.org
      Cc:
      Data: Tue, 2 Jun 2020 00:26:07 +0200
      Oggetto: Info on "lost" PR

      Hi Daniel,
      sorry if I write directly to you, but I need help to understand the right path to complete the PR.
      Some time ago you approved one of my PR https://github.com/OCA/management-system/pull/265 (my first on OCA ;-)), but I have other that are waiting:
      264, 266, 267, 282, 283, 284, 286 and the porting of 265: 325 and 326.
      There is some procedure to request revisions or your team do it based on community necessity/priority?
      Some hint?

      Thanks in advance

      Stefano Consolaro
      www.mymage.it


      Stefano Consolaro
      www.mymage.it
      by Stefano Consolaro - 12:31 - 2 Jun 2020
    • Info on "lost" PR
      Hi Daniel,
      sorry if I write directly to you, but I need help to understand the right path to complete the PR.
      Some time ago you approved one of my PR https://github.com/OCA/management-system/pull/265 (my first on OCA ;-)), but I have other that are waiting:
      264, 266, 267, 282, 283, 284, 286 and the porting of 265: 325 and 326.
      There is some procedure to request revisions or your team do it based on community necessity/priority?
      Some hint?

      Thanks in advance

      Stefano Consolaro
      www.mymage.it
      by Stefano Consolaro - 12:31 - 2 Jun 2020
    • Re: Add v 12.0 to Fleet
      Perfet! Thank you Daniel!


      Da: "Daniel Reis" dreis@opensourceintegrators.com
      A: "Contributors" contributors@odoo-community.org
      Cc:
      Data: Mon, 01 Jun 2020 13:31:55 -0000
      Oggetto: Re: Add v 12.0 to Fleet

      Done!

      On 31/05/2020 22:21, Stefano Consolaro wrote:
      Hi,
      in https://github.com/OCA/fleet I see only v.13 branch.
      It is possible to have v.12 too?
      I have a micro module to propose.
      Thanks

      Stefano Consolaro


      Stefano Consolaro
      www.mymage.it
      by Stefano Consolaro - 05:51 - 1 Jun 2020