Contributors

• Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

  Hi Moises,

  
  

  I just created the repo: https://github.com/OCA/odoo-pre-commit-hooks/

  
  

  Best regards,

  
  

  -sbi
  

  
  

  On Mon, Jun 27, 2022 at 10:12 PM Moises Lopez <moylop260@vauxoo.com> wrote:
  

  Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

  
  

  Now, we are using pre-commit for new projects.

  
  

  So we can remove all the checks unrelated with python from pylint-odoo

  e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

  
  

  Then they could be replaced in the pre-commit configuration file with the id of the related check

  
  

  e.g. eslint see https://github.com/pre-commit/mirrors-eslint

  
  

  There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment

  But it is duplicated with the following hook id fix-encoding-pragma from:

   - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

  
  

  It even has the option to auto-fix it

  
  

  Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
  

   - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

  
  

  Similar case for pylint-odoo check wrong-tabs-instead-of-spaces

   - https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py
  

  
  

  They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

  
  

  But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

  
  

  In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

  
  

  Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files

  And pylint-odoo doesn't have the auto-fix option

  
  

  e.g. for XML files: 

   - dangerous-filter-wo-user

   - duplicate-xml-record-id

   - deprecated-openerp-xml-node
   - create-user-wo-reset-password
   - duplicate-xml-fields
   - redundant-modulename-xml
   - deprecated-data-xml-node
  

  
  

  e.g. for CSV files:

   - duplicate-id-csv

  
  

  e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):

   - duplicate-po-message-definition

   - po-msgstr-variables
  

  
  

  So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

  
  

  The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:

   - https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

  
  

  And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

  
  

  Check the following discussion about creating custom repository to detect and autofix:

   - https://github.com/OCA/pylint-odoo/issues/375

  
  

  Check the following discussion about deprecating duplicated checks if pre-commit supports:

   - https://github.com/OCA/pylint-odoo/issues/267
  

  
  

  Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:

   - https://github.com/OCA/pylint-odoo/issues/381

  
  

  If you agree, Could you help us to create the repository in OCA, please?

  
  

  --
  

  Moisés López Calderón

  Mobile: (+521) 477-752-22-30

  Twitter: @moylop260

  hangout: moylop260@vauxoo.com
  http://www.vauxoo.com - Odoo Gold Partner

  Twitter: @vauxoo

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  ---

  by Stéphane Bidoul - 11:15 - 29 Jun 2022

• Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

  Hi Moises,

  
  

  Sounds great to make pylint-odoo simpler!

  
  

  I take the opportunity to mention the semgrep (https://semgrep.dev) project that I recently discovered and may be a simple solution to implement some checks.
  

  
  

  I'll create the new repo soon.

  
  

  > Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?

  
  

  Once the new checkers/fixers are ready in the new repo(s), they will need to be referenced in the .pre-commit-config.yaml template in the addons repo template.
  

  
  

  Best regards,

  
  

  -sbi
  

  
  

  On Tue, Jun 28, 2022 at 9:52 AM Daniel Reis <dreis@opensourceintegrators.com> wrote:
  

  Thank you for taking care of this Moises.

  
  

  Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?
  
  

  --dr 

  
  

  No dia 28/06/2022, às 07:46, Mignon, Laurent <laurent.mignon@acsone.eu> escreveu:
  
  

  

  Good Idea!

  
  

  Regards.

  
  

  On Tue, Jun 28, 2022 at 8:17 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
  

  Yes, I agree.

  
  

  Regards.
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  ---

  by Stéphane Bidoul - 12:41 - 28 Jun 2022

• Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

  I have done a big progress in this subject recently, and it's open sourced. Get it here: https://gitlab.com/moduon/devsecops/precommix

  
  

  It's based on Nix, so you will never get another random failure. It's a definitive solution for problems such as:

  • https://github.com/OCA/oca-addons-repo-template/issues/133
  • https://github.com/OCA/oca-addons-repo-template/pull/143

  Your pre-commit configurations will keep working forever.

  
  

  Just go ahead and wire precommix with oca-addons-repo-template.

  
  

  Apart from that, I agree on removing the non-python stuff from pylint-odoo.

  ---

  by Jairo Llopis - 11:16 - 28 Jun 2022

• Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

  Great ! +1

  
  

  On Mon, Jun 27, 2022 at 10:12 PM Moises Lopez <moylop260@vauxoo.com> wrote:
  

  Currently, we are using pylint-odoo project as pre-commit hooks for other kind of files

  
  

  Now, we are using pre-commit for new projects.

  
  

  So we can remove all the checks unrelated with python from pylint-odoo

  e.g. eslint (javascript lints), XML checks, PO (translations) checks and so on

  
  

  Then they could be replaced in the pre-commit configuration file with the id of the related check

  
  

  e.g. eslint see https://github.com/pre-commit/mirrors-eslint

  
  

  There are other custom checks in pylint-odoo as unnecessary-utf8-coding-comment

  But it is duplicated with the following hook id fix-encoding-pragma from:

   - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/fix_encoding_pragma.py

  
  

  It even has the option to auto-fix it

  
  

  Similar case for pylint-odoo check incoherent-interpreter-exec-perm:
  

   - https://github.com/pre-commit/pre-commit-hooks/blob/main/pre_commit_hooks/check_executables_have_shebangs.py

  
  

  Similar case for pylint-odoo check wrong-tabs-instead-of-spaces

   - https://github.com/Lucas-C/pre-commit-hooks/blob/master/pre_commit_hooks/remove_tabs.py
  

  
  

  They are duplicated from pylint-odoo and they are better since they have the option to auto-fix if you want.

  
  

  But there are other kinds of custom checks in pylint-odoo unrelated with python files that could be good to create a new pre-commit-hook custom for Odoo modules

  
  

  In order to check XMLs, PO, CSS, CSV, and so on in the context of Odoo modules.

  
  

  Currently, pylint-odoo is overloaded trying to do checks for non-python code since the core is not supporting check non-python files

  And pylint-odoo doesn't have the auto-fix option

  
  

  e.g. for XML files: 

   - dangerous-filter-wo-user

   - duplicate-xml-record-id

   - deprecated-openerp-xml-node
   - create-user-wo-reset-password
   - duplicate-xml-fields
   - redundant-modulename-xml
   - deprecated-data-xml-node
  

  
  

  e.g. for CSV files:

   - duplicate-id-csv

  
  

  e.g. for PO files (Maybe, If we look for if exists hooks related to PO files they could be already developed from another hook project, so use it instead):

   - duplicate-po-message-definition

   - po-msgstr-variables
  

  
  

  So, IMHO in OCA we need to create a new project to push all these custom pre-commit hooks and add documentation of the useful projects replacing pylint-odoo checks.

  
  

  The name proposal is oca/odoo-pre-commit-hooks similar to main hooks repository:

   - https://github.com/pre-commit/pre-commit-hooks/tree/main/pre_commit_hooks

  
  

  And we can (or not) enable the option to auto fix (we can even push checks without auto fix)

  
  

  Check the following discussion about creating custom repository to detect and autofix:

   - https://github.com/OCA/pylint-odoo/issues/375

  
  

  Check the following discussion about deprecating duplicated checks if pre-commit supports:

   - https://github.com/OCA/pylint-odoo/issues/267
  

  
  

  Check the following plan to create a freeze branch in pylint-odoo with the current behavior in pro to create a new version with new focus and clean code, delete old unused checks, deprecate py2 and so on:

   - https://github.com/OCA/pylint-odoo/issues/381

  
  

  If you agree, Could you help us to create the repository in OCA, please?

  
  

  --
  

  Moisés López Calderón

  Mobile: (+521) 477-752-22-30

  Twitter: @moylop260

  hangout: moylop260@vauxoo.com
  http://www.vauxoo.com - Odoo Gold Partner

  Twitter: @vauxoo

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  
  

  
  

  --
  

  
  Denis Roussel
  Software Engineer
  T    : +32 2 888 31 49
  M : +32 472 22 00 57

  
  

  
  

  Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
  

  Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium

  Zone industrielle 22 | L-8287 Kehlen | Luxembourg
  

  ---

  by Denis Roussel - 10:51 - 28 Jun 2022

• Re: New repository oca/odoo-pre-commit-hooks and pylint-odoo deep refactoring

  Thank you for taking care of this Moises.

  
  

  Question: how does this coordinate with the OCA repo template? Pre commit hooks are currently maintained there, right?
  
  

  --dr 

  
  

  No dia 28/06/2022, às 07:46, Mignon, Laurent <laurent.mignon@acsone.eu> escreveu:
  
  

  

  Good Idea!

  
  

  Regards.

  
  

  On Tue, Jun 28, 2022 at 8:17 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
  

  Yes, I agree.

  
  

  Regards.
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  ---

  by Daniel Reis - 09:51 - 28 Jun 2022

3 more replies