Contributors

• Re: /ocabot rebase and improved addons table

  Thanks!
  

  
  

  On Fri, 13 Aug 2021 at 10:57, Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:
  

  Hi folks!

  
  

  I just deployed a new version of our GitHub bot with the following new features:
  

  
  

  A new /ocabot rebase command (contributed by Miquel Raïch).

  
  

  An update to the README.md addons table generator to show the addons maintainers (contributed by Sylvain Le Gal).

  
  

  Have a nice day,

  
  

  -sbi

  
  

  --

  Stéphane Bidoul | @SBidoul
  

  Acsone sa/nv | http://acsone.eu/ | +32 2 888 3120

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  
  
  --
  

  Lorenzo Battistini
  https://github.com/eLBati

  takobi.online | Facebook | Linkedin | Youtube

  ---

  by Lorenzo Battistini. - 05:35 - 19 Aug 2021

• Re: /ocabot rebase and improved addons table

  Yes, indeed any improvement is welcome.

  
  

  Regards.
  

  ---

  by Pedro M. Baeza - 12:05 - 13 Aug 2021

• Re: /ocabot rebase and improved addons table

  OK ! thanks for the info. I didn't know.

  
  

  Well, we can hope that such github limitation will be dropped.
  

  
  

  anyway, I think its a good step forward, because it allows to rebase many PRs, and I think that Acsone, ForgeFlow, Tecnativa members teams are quite reactive when we ask to rebase.

  
  

  
  

  
  

  
  

  Sylvain LE GAL - Twitter
  

  GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

  Site Web | FramaSphere | Facebook
  3 Grande rue des Feuillants, 69001 Lyon
  Standard : (+33) 09.72.32.33.17
  

  Service Informatique : (+33) 09.73.79.64.40

  Astreinte Informatique : (+33) 06.81.85.61.43

  Member of the OCA (Odoo Community Association)
  

  Web Site | Twitter
  

  
  

  
  

  Le ven. 13 août 2021 à 11:52, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> a écrit :
  

  Sylvain, it's not something that can be decided when the branch from which you make the pull request belongs to an organization instead of an individual user. GitHub doesn't allow you to push to that branches even if the pull request has that check marked. I don't understand such limitation, but it's there, and most of the regular contributors (Acsone, ForgeFlow, Tecnativa, etc) use this technique for allowing anyone in the team to handle the PR.

  
  

  I understand then that this command can't be used in such PRs.
  

  
  

  Regards.
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  ---

  by Sylvain LE GAL - 12:00 - 13 Aug 2021

• Re: /ocabot rebase and improved addons table

  Sylvain, it's not something that can be decided when the branch from which you make the pull request belongs to an organization instead of an individual user. GitHub doesn't allow you to push to that branches even if the pull request has that check marked. I don't understand such limitation, but it's there, and most of the regular contributors (Acsone, ForgeFlow, Tecnativa, etc) use this technique for allowing anyone in the team to handle the PR.

  
  

  I understand then that this command can't be used in such PRs.
  

  
  

  Regards.
  

  ---

  by Pedro M. Baeza - 11:50 - 13 Aug 2021

• Re: /ocabot rebase and improved addons table

  > I have the same question as Pedro has. I suppose the command will do the rebase only if the maintainer is allowed to push to the forked repo.

  
  

  Indeed, but this is the default when creating new PR. And if the developper that makes the PR disable that feature, we should not by pass that.

  
  

  see below :
  

  
  

  
  
  

  
  

  
  

  Sylvain LE GAL - Twitter
  

  GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)

  Site Web | FramaSphere | Facebook
  3 Grande rue des Feuillants, 69001 Lyon
  Standard : (+33) 09.72.32.33.17
  

  Service Informatique : (+33) 09.73.79.64.40

  Astreinte Informatique : (+33) 06.81.85.61.43

  Member of the OCA (Odoo Community Association)
  

  Web Site | Twitter
  

  
  

  
  

  Le ven. 13 août 2021 à 11:32, Aarón Henríquez Quintana <ahenriquez@forgeflow.com> a écrit :
  

  Awesome! Thank you Miquel, Stéphane.

  
  

  I have the same question as Pedro has. I suppose the command will do the rebase only if the maintainer is allowed to push to the forked repo.

  
  

  Regards.

  
  

  On Fri, 13 Aug 2021 at 11:12, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
  

  Great improvements, thanks!

  
  

  I wonder if the rebase command will work on organization branches, where by default maintainers can't update the pull request branch.

  
  

  Regards.
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  _______________________________________________
  Mailing-List: https://odoo-community.org/groups/contributors-15
  Post to: mailto:contributors@odoo-community.org
  Unsubscribe: https://odoo-community.org/groups?unsubscribe
  

  ---

  by Sylvain LE GAL - 11:41 - 13 Aug 2021

  1 attachments 1 attachments

  image.png

3 more replies