Archives
Contributors
Pull request modifying two modules?
Hello, Is the Odoo bot capable handle a PR changing more than one module? For example, if I add a fix involving two modules at the same time, will it be able to properly bump the versions of both of them? Asking for a friend. (Not really.) Thanks Daniel
by Daniel Reis - 05:05 - 1 Oct 2020
Follow-Ups
-
Re: Pull request modifying two modules?
Yeah, of course there are scenarios where it makes sense to not split the PR, so go ahead!Regards.
by Pedro M. Baeza - 05:55 - 1 Oct 2020 -
Re: Pull request modifying two modules?
Thank you Pedro, I'll be sure to let my friend know that ;-) Seriously now, it is a fix in two closely related modules, and I don't see a case where one could be merged and the other not. Two PRs world would be more confusing than helpful. Still, making it in separate commits seems wise advice. Thanks Daniel On 01/10/2020 16:12, Pedro M. Baeza (Tecnativa) wrote: > Yes, bot does it correctly thanks to the great work of Stephane Bidoul :) > > Now, about the guidelines, you can do that on a PR if the task is very > related. Think if a separation in several commits is advisable or not > anyway. > > Regards. > > _______________________________________________ > Mailing-List: https://odoo-community.org/groups/contributors-15 > <https://odoo-community.org/groups/contributors-15> > Post to: mailto:contributors@odoo-community.org > Unsubscribe: https://odoo-community.org/groups?unsubscribe > <https://odoo-community.org/groups?unsubscribe> >
by Daniel Reis - 05:50 - 1 Oct 2020 -
Re: Pull request modifying two modules?
Yes, bot does it correctly thanks to the great work of Stephane Bidoul :)Now, about the guidelines, you can do that on a PR if the task is very related. Think if a separation in several commits is advisable or not anyway.Regards.
by Pedro M. Baeza - 05:11 - 1 Oct 2020