Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: 100 % coverage not enough?

Archives

Contributors

Re: 100 % coverage not enough?

Re: 100 % coverage not enough?

Re: 100 % coverage not enough?

El vie, 08-09-2023 a las 18:57 +0000, Ronald Portier escribió:
Supposedly the PR would decrease the overall coverage percentage. How??

The 1st thing you need to know is that hose checks are not required.

Now, this is how your PR looks:


That ✅ is telling the reviewer that the PR has a 100% of coverage. That's the important part.

The ❌ however is the weirdo. Sometimes it happens, so I systematically ignore that check. IMHO it could be removed. My guess is that the base branch evolved and got more coverage, and that if you rebased it would always increase. But maybe it's just a bug somewhere.
by Jairo Llopis - 10:11 - 11 Sep 2023

1 attachments 1 attachments

Imagen-VDE3A2.png

Reference

  • 100 % coverage not enough? 
    Hi all,


I submitted a PR with 100% code coverage to the account-invoicing repo.


However the branch is red because 100% is apparently not enough. 
Supposedly the PR would decrease the overall coverage percentage. How??


See here: https://github.com/OCA/account-invoicing/pull/1544


I think any PR that gets code coverage > 90% (and that does not decrease 
coverage of an existing module), should get a branch green, but 
certainly 100%.


Kind regards, Ronald
    by "Ronald Portier" <rportier@therp.nl> - 08:56 - 8 Sep 2023