Archives
Contributors
Re: Adopt an addon
Hi Tom,
On Tue, Aug 3, 2021 at 4:51 PM Tom <tom@sunflowerweb.nl> wrote:
Thanks so much! Does it also mean that a maintainer can merge his own pull requests on a module, thereby do unreviewed development?
On this topic, the maintainer role description says "Maintainers may proceed to some maintenance operation with relaxed
code review rules (e.g. performing simple, low risk, forward and
backports, maintaining documentation, applying cosmetic
improvements to the code such as linting). Maintainers are
expected to follow the highest quality standard when performing
such operations."
So yes, more freedom, but also more responsibilities :)
-sbi
by Stéphane Bidoul - 06:35 - 3 Aug 2021
Reference
-
Adopt an addon
Hi,As you may have noticed, our faithful bot is now calling for addon maintainers.When a contributor submits a pull request on an addon that does not have declared maintainers it emits a friendly comment suggesting the author to become a maintainer.As a reminder, the maintainer role is described at https://odoo-community.org/page/maintainer-role.In a nutshell it is a way to claim that you care about a particular module. This gives you some responsibilities, but also benefits such as receiving notifications when PRs are made on the modules you maintain, and the possibility to merge pull requests without being a full PSC member.A huge thank you to Lorenzo Battistini who contributed this feature to the OCA GitHub bot.Enjoy,-sbi--
by Stéphane Bidoul - 07:40 - 2 Aug 2021-
Re: Adopt an addon
Hi Tom,On Tue, Aug 3, 2021 at 4:51 PM Tom <tom@sunflowerweb.nl> wrote:Thanks so much! Does it also mean that a maintainer can merge his own pull requests on a module, thereby do unreviewed development?On this topic, the maintainer role description says "Maintainers may proceed to some maintenance operation with relaxed code review rules (e.g. performing simple, low risk, forward and backports, maintaining documentation, applying cosmetic improvements to the code such as linting). Maintainers are expected to follow the highest quality standard when performing such operations."So yes, more freedom, but also more responsibilities :)-sbi
by Stéphane Bidoul - 06:35 - 3 Aug 2021 -
Re: Adopt an addon
> Thanks so much! Does it also mean that a maintainer can merge his own pull requests on a module, thereby do unreviewed development?He can, but he should not ! (as all people having write access on oca repositories : board member, PSC member, etc...)GRAP - Service informatique (Groupement Régional Alimentaire de Proximité)Site Web | FramaSphere | Facebook
3 Grande rue des Feuillants, 69001 Lyon
Standard : (+33) 09.72.32.33.17Service Informatique : (+33) 09.73.79.64.40Astreinte Informatique : (+33) 06.81.85.61.43Member of the OCA (Odoo Community Association)Le mar. 3 août 2021 à 16:51, Tom <tom@sunflowerweb.nl> a écrit :Thanks so much! Does it also mean that a maintainer can merge his own pull requests on a module, thereby do unreviewed development?
Aug 3, 2021 11:47:32 Francesco Apruzzese <cescoap@gmail.com>:
Great! Thank you guys!
Il giorno lun 2 ago 2021 alle ore 19:42 Stéphane Bidoul <stephane.bidoul@acsone.eu> ha scritto:
Hi,
As you may have noticed, our faithful bot is now calling for addon maintainers.
When a contributor submits a pull request on an addon that does not have declared maintainers it emits a friendly comment suggesting the author to become a maintainer.
As a reminder, the maintainer role is described at https://odoo-community.org/page/maintainer-role.
In a nutshell it is a way to claim that you care about a particular module. This gives you some responsibilities, but also benefits such as receiving notifications when PRs are made on the modules you maintain, and the possibility to merge pull requests without being a full PSC member.
A huge thank you to Lorenzo Battistini who contributed this feature to the OCA GitHub bot.
Enjoy,
-sbi
--_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--
Francesco Apruzzese
Profilo professionale: http://it.linkedin.com/in/francescoapruzzese
Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.
Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Sylvain LE GAL - 05:21 - 3 Aug 2021 -
Re: Adopt an addon
Great! Thank you guys!Il giorno lun 2 ago 2021 alle ore 19:42 Stéphane Bidoul <stephane.bidoul@acsone.eu> ha scritto:Hi,As you may have noticed, our faithful bot is now calling for addon maintainers.When a contributor submits a pull request on an addon that does not have declared maintainers it emits a friendly comment suggesting the author to become a maintainer.As a reminder, the maintainer role is described at https://odoo-community.org/page/maintainer-role.In a nutshell it is a way to claim that you care about a particular module. This gives you some responsibilities, but also benefits such as receiving notifications when PRs are made on the modules you maintain, and the possibility to merge pull requests without being a full PSC member.A huge thank you to Lorenzo Battistini who contributed this feature to the OCA GitHub bot.Enjoy,-sbi--_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Francesco ApruzzeseProfilo professionale: http://it.linkedin.com/in/francescoapruzzese
Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.
Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.
by Francesco Apruzzese - 11:46 - 3 Aug 2021 -
Re: Adopt an addon
Thanks!Sergio CoratoIl giorno mar 3 ago 2021 alle ore 09:22 Alex Comba <alex.comba@agilebg.com> ha scritto:Great! Thanks, Lorenzo and Stéphane!On Mon, Aug 2, 2021 at 7:41 PM Stéphane Bidoul <stephane.bidoul@acsone.eu> wrote:Hi,As you may have noticed, our faithful bot is now calling for addon maintainers.When a contributor submits a pull request on an addon that does not have declared maintainers it emits a friendly comment suggesting the author to become a maintainer.As a reminder, the maintainer role is described at https://odoo-community.org/page/maintainer-role.In a nutshell it is a way to claim that you care about a particular module. This gives you some responsibilities, but also benefits such as receiving notifications when PRs are made on the modules you maintain, and the possibility to merge pull requests without being a full PSC member.A huge thank you to Lorenzo Battistini who contributed this feature to the OCA GitHub bot.Enjoy,-sbi--_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Alex Comba
Tel (CH): +41 91 210 23 40_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Sergio Corato - 10:31 - 3 Aug 2021
-