- Mailing Lists
- Contributors
- Re: Empty SQL argument and ANY operator
Archives
- By thread 1419
-
By date
- August 2019 59
- September 2019 118
- October 2019 165
- November 2019 97
- December 2019 35
- January 2020 58
- February 2020 204
- March 2020 121
- April 2020 172
- May 2020 50
- June 2020 158
- July 2020 85
- August 2020 94
- September 2020 193
- October 2020 277
- November 2020 100
- December 2020 159
- January 2021 38
- February 2021 87
- March 2021 146
- April 2021 73
- May 2021 90
- June 2021 86
- July 2021 123
- August 2021 50
- September 2021 68
- October 2021 66
- November 2021 74
- December 2021 75
- January 2022 98
- February 2022 77
- March 2022 68
- April 2022 31
- May 2022 59
- June 2022 87
- July 2022 141
- August 2022 38
- September 2022 73
- October 2022 152
- November 2022 39
- December 2022 50
- January 2023 93
- February 2023 49
- March 2023 106
- April 2023 47
- May 2023 69
- June 2023 92
- July 2023 64
- August 2023 103
- September 2023 91
- October 2023 101
- November 2023 94
- December 2023 46
- January 2024 75
- February 2024 79
- March 2024 104
- April 2024 63
- May 2024 40
- June 2024 160
- July 2024 80
- August 2024 70
- September 2024 62
- October 2024 121
- November 2024 117
- December 2024 89
- January 2025 59
- February 2025 104
- March 2025 96
- April 2025 107
- May 2025 52
- June 2025 72
- July 2025 60
- August 2025 81
- September 2025 124
- October 2025 63
- November 2025 22
Contributors
Re: Empty SQL argument and ANY operator
Looks like a bug indeed, in 14.0 and lower. In 15.0 the code seems refactored.
>>> env.cr.execute("select count(1) from res_users where
id != any(%s)", (([1,],)))
>>> env.cr.query
b'select count(1) from res_users where id != any(ARRAY[1])'
>>> env.cr.fetchall()
[(248,)]
>>> env.cr.execute("select count(1) from res_users where
id != any(%s)", (([],)))
>>> env.cr.query
b"select count(1) from res_users where id != any('{}')"
>>> env.cr.fetchall()
[(0,)]
Probably the Odoo programmers misinterpreted what kind of query
psycopg would generate in such a case.
I forgot again that this OCA's mailing-list bug is not fixed (if someone interested: https://github.com/decgroupe/odoo-ocb/commit/5d07dba81e05d44fdbd593017e13de5c22a1c46e)
You can see the image here: https://odoo-community.org/groups/contributors-15/contributors-1702031?mode=thread&date_begin=&date_end=The relevant code is: https://github.com/odoo/odoo/blob/b7777c50d40cc56e094f43d8f35753d713e17f77/addons/mail/models/mail_thread.py#L2523-L2541
--
Yann PAPOUIN, Ingénieur R&D | DEC
Le mer. 21 févr. 2024 à 15:12, Tom Blauwendraat <notifications@odoo-community.org> a écrit :
For some reason I can't see the image, can you maybe send it as attachment?
Also, can you provide a link to the relevant part of the Odoo source code that defines "except_partner"?
On 2/21/24 12:52, Yann Papouin wrote:
Hello everyone,
I'm trying to debug Odoo 14.0 to understand why some emails received on one of our public channel are not forwarded to all members of the list.
The SQL query is made to retrieve all partners members of a channel that will be notified with a copy of the received email
I tracked down the issue to the fact that an empty list (except_partner) is converted to '{}' (empty array literal) when used as an argument in the SQL query and the result of the query with this condition is always empty.
I'm pretty sure that it is something tricky around the SQL language but as I'm not an expert on this, I don't know how to fix it.My current dirty fix is to add except_partner.append(0) to have a valid query but I would prefer to have the real SQL fix.
Any idea ?
--
Yann PAPOUIN, Ingénieur R&D | DEC_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Tom Blauwendraat - 07:51 - 21 Feb 2024
Reference
-
Empty SQL argument and ANY operator
Hello everyone,I'm trying to debug Odoo 14.0 to understand why some emails received on one of our public channel are not forwarded to all members of the list.The SQL query is made to retrieve all partners members of a channel that will be notified with a copy of the received emailI tracked down the issue to the fact that an empty list (except_partner) is converted to '{}' (empty array literal) when used as an argument in the SQL query and the result of the query with this condition is always empty.I'm pretty sure that it is something tricky around the SQL language but as I'm not an expert on this, I don't know how to fix it.My current dirty fix is to add except_partner.append(0) to have a valid query but I would prefer to have the real SQL fix.
Any idea ?--
Yann PAPOUIN, Ingénieur R&D | DEC
by Yann Papouin - 12:52 - 21 Feb 2024