Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: Move purchase_request* and purchase_work_acceptance*

Archives

Contributors

Re: Move purchase_request* and purchase_work_acceptance*

Re: Move purchase_request* and purchase_work_acceptance*

Re: Move purchase_request* and purchase_work_acceptance*

El mar, 21 dic 2021 a las 13:32, Yann Papouin (<ypa@decgroupe.com>) escribió:
As I was in that case, why not creating a file with the same name for each moved module with a text content:
Module moved to repository xxxxx


In my experience, that's more maintenance burden on our part with no reward because people still don't look.

Regards.
by Pedro M. Baeza - 01:41 - 21 Dec 2021

Reference

  • Move purchase_request* and purchase_work_acceptance*
    Hi all,

    To reduce purchase-workflow repository size, I would suggest to create two new repositories in order to speed up tests.

    Thanks
    --

    Denis Roussel
    Software Engineer
    T    : +32 2 888 31 49
    M : +32 472 22 00 57


    Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
    Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium
    Zone industrielle 22 | L-8287 Kehlen | Luxembourg
    by Denis Roussel - 09:35 - 14 Dec 2021

    11 replies 11 replies

    • Re: Move purchase_request* and purchase_work_acceptance*
      We can use readme to store this information. One file, all the info.

      Il giorno mar 21 dic 2021 alle ore 13:32 Yann Papouin <ypa@decgroupe.com> ha scritto:
      As I was in that case, why not creating a file with the same name for each moved module with a text content:
      Module moved to repository xxxxx

      --
      Yann PAPOUIN, Ingénieur R&D | DEC


      Le mar. 21 déc. 2021 à 11:27, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> a écrit :
      Now that having a lot of runboat instances is not too much of a problem, I think it's better to split the maximum repos for smaller sets of modules, so I will go to all of them that we are talking about. Reducing the number of them will:

      - Avoid potential conflicts between them.
      - Reduce tests size.

      On the contrary, it makes the ecosystem a bit more complicated, and gets people used to look to other places. When we unfolded OCA/hr into several repos, including OCA/hr-holidays and OCA/hr-expense, some people still created PRs to migrate one module that is already migrated, but on the other repo. But the problem here is that people don't look, and it happens constantly, not only with this, so no big deal.

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Francesco Apruzzese

      Profilo professionale: http://it.linkedin.com/in/francescoapruzzese

      Il contenuto di questo messaggio elettronico è riservato e tutelato dal segreto professionale ed è rivolto esclusivamente al/ai destinatario/i identificato/i. Pertanto è proibito leggerlo, copiarlo, divulgarlo o utilizzarlo da parte di chiunque salvo il/i destinatario/i. Se non siete il destinatario, vi invitiamo a cancellare il messaggio ed eventuali allegati dandocene immediatamente comunicazione scritta a mezzo posta elettronica.
      This e-mail and any attachments are confidential and may contain information intended for the addressee(s) only. Reading, copying, disclosure or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail.

      Non stampare questa email se non strettamente necessario. Aiuta te ed aiuta l'ambiente.
      by Francesco Apruzzese - 02:01 - 21 Dec 2021
    • Re: Move purchase_request* and purchase_work_acceptance*
      El mar, 21 dic 2021 a las 13:32, Yann Papouin (<ypa@decgroupe.com>) escribió:
      As I was in that case, why not creating a file with the same name for each moved module with a text content:
      Module moved to repository xxxxx


      In my experience, that's more maintenance burden on our part with no reward because people still don't look.

      Regards.
      by Pedro M. Baeza - 01:41 - 21 Dec 2021
    • Re: Move purchase_request* and purchase_work_acceptance*
      As I was in that case, why not creating a file with the same name for each moved module with a text content:
      Module moved to repository xxxxx

      --
      Yann PAPOUIN, Ingénieur R&D | DEC


      Le mar. 21 déc. 2021 à 11:27, Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> a écrit :
      Now that having a lot of runboat instances is not too much of a problem, I think it's better to split the maximum repos for smaller sets of modules, so I will go to all of them that we are talking about. Reducing the number of them will:

      - Avoid potential conflicts between them.
      - Reduce tests size.

      On the contrary, it makes the ecosystem a bit more complicated, and gets people used to look to other places. When we unfolded OCA/hr into several repos, including OCA/hr-holidays and OCA/hr-expense, some people still created PRs to migrate one module that is already migrated, but on the other repo. But the problem here is that people don't look, and it happens constantly, not only with this, so no big deal.

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Yann Papouin - 01:31 - 21 Dec 2021
    • Re: Move purchase_request* and purchase_work_acceptance*
      I agree with Pedro.

      The amount of modules is not the only factor to take into account.

      The aim of a repository is also to group functionally modules that do 'quite' the same things and has a specific meaning (I don't like *-workflow stuff as it is too generic - @kitti don't create  purchase-extra-workflow as it adds abstraction and has no meaning).

      To find modules, we have our shop that leads to the good repository (we maybe need to do marketing on this)

      On Tue, Dec 21, 2021 at 11:27 AM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
      Now that having a lot of runboat instances is not too much of a problem, I think it's better to split the maximum repos for smaller sets of modules, so I will go to all of them that we are talking about. Reducing the number of them will:

      - Avoid potential conflicts between them.
      - Reduce tests size.

      On the contrary, it makes the ecosystem a bit more complicated, and gets people used to look to other places. When we unfolded OCA/hr into several repos, including OCA/hr-holidays and OCA/hr-expense, some people still created PRs to migrate one module that is already migrated, but on the other repo. But the problem here is that people don't look, and it happens constantly, not only with this, so no big deal.

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --

      Denis Roussel
      Software Engineer
      T    : +32 2 888 31 49
      M : +32 472 22 00 57


      Val Benoit, Quai Banning 6 | B-4000 Liège | Belgium
      Atrium Building, Drève Richelle 167 | B-1410 Waterloo | Belgium
      Zone industrielle 22 | L-8287 Kehlen | Luxembourg
      by Denis Roussel - 11:50 - 21 Dec 2021
    • Re: Move purchase_request* and purchase_work_acceptance*
      Hi,

      I don't have a strong opinion on this one, if you want to split purchase-workflow, I'm fine with that.

      For me the real problem, and to bring another consideration to the table, are the repos with "rebel" addons that forces you to have multiple pipelines with some addons excluded and other with them included, it happens often that a contributor ends having to fix other modules tests when you opening a new PR of a new module. This happens in purchase-workflow but also in sale-workflow.

      Regards,

      El mar, 21 dic 2021 a las 11:27, Pedro M. Baeza (Tecnativa) (<pedro.baeza@tecnativa.com>) escribió:
      Now that having a lot of runboat instances is not too much of a problem, I think it's better to split the maximum repos for smaller sets of modules, so I will go to all of them that we are talking about. Reducing the number of them will:

      - Avoid potential conflicts between them.
      - Reduce tests size.

      On the contrary, it makes the ecosystem a bit more complicated, and gets people used to look to other places. When we unfolded OCA/hr into several repos, including OCA/hr-holidays and OCA/hr-expense, some people still created PRs to migrate one module that is already migrated, but on the other repo. But the problem here is that people don't look, and it happens constantly, not only with this, so no big deal.

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe



      --
      Lois Rilo Antelo
      Odoo consultant at ForgeFlow S.L.
      by Lois Rilo Antelo - 11:46 - 21 Dec 2021