Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: New module derived from Odoo CE licensing/credits question

Archives

Contributors

Re: New module derived from Odoo CE licensing/credits question

Re: New module derived from Odoo CE licensing/credits question

Re: New module derived from Odoo CE licensing/credits question

Holger,

 

thanx for an input. I initially thought to make it in a way so that both modules can work side-by-side. But that is probably pretty useless so your idea is actually pretty good and would make the module really small.

 

The code and templates I removed are for product.attribute.category for product.attribute to group them. I think I cannot (can I?) disable the code so the additional object/table/column will be there. However I would like to disable the templates relating to these so they do not confuse the user. According to a Google search it can be done in this way:

 

<record id="full_external_id_of_the_template" model="ir.ui.view">
        <field name="active" eval="False"/>
</record>

 

If I uninstall my module will the active statu return to its previous state? Should I use anything like that or just document in the readme that the product.attribute.category is useless while using custom.info?

 

Best regards

 

Radovan

 

On piatok 30. júla 2021 13:47:19 CEST Holger Brunn wrote:

> > Would such module be acceptable for OCA? Any comments

> > are welcome. Best regards

>

> shouldn't be very different than backporting an Odoo SA module, right?

> https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/

> CONTRIBUTING.rst#backporting-odoo-modules

> But if there's so little changes, why can't you just depend on the module

> and change what's to be changed in your code?

> _______________________________________________

> Mailing-List: https://odoo-community.org/groups/contributors-15 [1]

> Post to: mailto:contributors@odoo-community.org

> Unsubscribe: https://odoo-community.org/groups?unsubscribe [2]

>

>

>

> [1] https://odoo-community.org/groups/contributors-15

> [2] https://odoo-community.org/groups?unsubscribe

 

 

by Radovan Skolnik - 05:56 - 30 Jul 2021

Reference

  • New module derived from Odoo CE licensing/credits question 
    Hello,

I have modified module website_sale_comparison from Odoo CE into website_sale_custom_info_comparison to work with website_sale_custom_info (based on PR from 9.0 by Jairo Llopis - will create PR for 13.0 soon) which uses product_custom_info. The modifications are really minimal: removed some unneeded code and templates (as these are already present in custom_info), rework of method _prepare_categories_for_display of product.product to work with custom info and slight changes to template displaying the comparison table. So basically it is 90% Odoo code, 10% of modifications.

Licensing-vise it should be OK as Odoo is LGPL v3. However my understanding is that original author should be kept there if this was to be included in OCA repository. Any comments on how to do this properly? I mean shoudl I just put Odoo as one of the authors or look up commits to these files in git? Would such module be acceptable for OCA?

Any comments are welcome. Best regards

	Radovan Skolnik
    by Radovan Skolnik - 01:21 - 30 Jul 2021