Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: New module derived from Odoo CE licensing/credits question

Archives

Contributors

Re: New module derived from Odoo CE licensing/credits question

Re: New module derived from Odoo CE licensing/credits question

Re: New module derived from Odoo CE licensing/credits question 

> The code and templates I removed are for product.attribute.category for

> product.attribute to group them. I think I cannot (can I?) disable the code

> so the additional object/table/column will be there. However I would like

> to disable the templates relating to these so they do not confuse the user.

> According to a Google search it can be done in this way:

you can rewrite any qweb template with inheritance before it's evaluated, so 
probably you can have some xpath and change the t-attributes, but


> <record id="full_external_id_of_the_template" model="ir.ui.view">

> <field name="active" eval="False"/>

> </record>

this seems much cleaner to me if it's the intention of this module to undo 
something the other module does entirely.


> If I uninstall my module will the active statu return to its previous state?

> Should I use anything like that or just document in the readme that the

> product.attribute.category is useless while using custom.info?

it doesn't, but you can add an uninstall_hook to your module that sets the 
active flag again.


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com
by Holger Brunn - 06:15 - 30 Jul 2021

1 attachments 1 attachments

signature.asc

Reference

  • New module derived from Odoo CE licensing/credits question 
    Hello,

I have modified module website_sale_comparison from Odoo CE into website_sale_custom_info_comparison to work with website_sale_custom_info (based on PR from 9.0 by Jairo Llopis - will create PR for 13.0 soon) which uses product_custom_info. The modifications are really minimal: removed some unneeded code and templates (as these are already present in custom_info), rework of method _prepare_categories_for_display of product.product to work with custom info and slight changes to template displaying the comparison table. So basically it is 90% Odoo code, 10% of modifications.

Licensing-vise it should be OK as Odoo is LGPL v3. However my understanding is that original author should be kept there if this was to be included in OCA repository. Any comments on how to do this properly? I mean shoudl I just put Odoo as one of the authors or look up commits to these files in git? Would such module be acceptable for OCA?

Any comments are welcome. Best regards

	Radovan Skolnik
    by Radovan Skolnik - 01:21 - 30 Jul 2021