Archives
Contributors
Re: OCA module contributors and migrations
A point of view could be that contributors should be someone who can answer any questions about the module in the future.Then it should have the expertise on the topic to do it.
- The "authors" list in manifest is something you want to keep small and just for important companies which contributed to the development, since it's also ugly when it's very long
- The contributors list in README can be as long as you want because it's not directly in anyone's view IMO - and I think any "thank you" that we can give people that invest their time in OCA, should be given
Just if people themselves feel their contribution is not worth a lot they can just not add it
by Jairo Llopis - 09:16 - 14 Jul 2021
Reference
-
OCA module contributors and migrations
Hi,This is about what counts as valid "contribution", that is, what you need to do to be added in the CONTRIBUTORS.rst file.In some (most?) cases, a migration is not a huge amount of work. In some cases, it can represent a lot of work.So it is arguable whether you should add yourself during migration commits.In discussions on Github, I have seen differing opinions on this subject. Some think it "cheapens" the contributor list that you add yourself if you just did a migration commit.I would lean towards adding yourself in any case a contributor anyways, since even if it's small it is still work, and should be recognized. Commit history is still there if you're interested in how much anyone contributed.Maybe there is already a consensus that I'm not aware of ? What do you think ?
by "Kevin Khao" <kevin.khao@akretion.com.br> - 04:46 - 13 Jul 2021-
Re: OCA module contributors and migrations
+1 JairoEl jue, 15 jul 2021 a las 11:07, Jairo Llopis (<jairo.llopis@tecnativa.com>) escribió:El jue, 15 de jul de 2021 a las 07:32:02 AM, Harald Panten Lopez <harald.panten@sygel.es> escribió:I think the responsibility to control these "fake contributors" shouldn't be for the modules authors but for PSC.Don't you think so?If a spammer properly migrates a module, let him spam!If he just fixes one typo in the readme, block that from being added to contributors.I think spam contributions are a valid point, but still anything like that should be recorded in the contribution guidelines too. How to identify a spammy contribution is a subject in itself that is interesting not only for OCA, so if somebody has a study on that, it would help here._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Harald Panten López
CEO
Sygel Technology S.L
+34 637 88 42 41 
harald.panten@sygel.es 
https://www.sygel.es 
C/ Àlaba 61, 5ª planta, 08005, Barcelona
by Harald Panten Lopez - 12:06 - 15 Jul 2021 -
Re: OCA module contributors and migrations
Hi Raphaël,I think the responsibility to control these "fake contributors" shouldn't be for the modules authors but for PSC.Don't you think so?El mié, 14 jul 2021 a las 19:42, Raphaël Valyi (<rvalyi@akretion.com>) escribió:Hello,I think it should be up to modules authors to decide if a contribution is worth getting mentioned or not as in any open source project. Don't like it? Then fork, but make sure you can do better or go back to your place. Indeed we already see some kind of "contribution squatting". I won't give names here but I have seen people forcing new pointless features into famous modules just to drive attention to their own company. This is very real already... Usually people doing this are not serious people, their trivial work won't be missed.And it didn't stop there, in some project you got noobs artificially inflating their image with non relevant contribs and starting to get their noob employee destroy serious modules... In Brazil so many companies failed their project because this kind of un responsable behaviors from noobs trying to auto promote them as expert at any cost to make a dent in the saas business...If you state rules like any tiny contrib is with a mention, soon enough you'll have contribution trolling exploding, just like during the Hacktober fest when gazillions of people were making pointless PRs to any project just to win a free T-shirt. Now think about getting it's company named along with Tecnativa or CamToCamp...This is sad, but this is the wild world we live in. Instead when module authors decide, then real efforts can be rewarded and notoriety squating may be avoided.Also bare in mind that one can always see the number of commits and lines changed in any git(hub) repo, so it's not like it's invisible either...On Wed, Jul 14, 2021, 6:26 AM Harald Panten Lopez <harald.panten@sygel.es> wrote:I think any migration should be considered as a contribution. As some of you said before, that may encourage more users to contribute.Any migration (even if it's a standard migration) needs an investment of time. On the other hand, when a user starts a migration he/she is "open" to receive suggestions, changes... Any migration is liable to become a headache.I agree that correcting a small typo (for example) wouldn't be enough for being considered as a contributor.Regards.El mié, 14 jul 2021 a las 9:17, Jairo Llopis (<jairo.llopis@tecnativa.com>) escribió:El mar, 13 de jul de 2021 a las 15:37:13 PM, David Beal <david.beal@akretion.com> escribió:A point of view could be that contributors should be someone who can answer any questions about the module in the future.Then it should have the expertise on the topic to do it.That sounds more like a maintainer.El mar, 13 de jul de 2021 a las 15:37:12 PM, Tom Blauwendraat <tom@sunflowerweb.nl> escribió:
- The "authors" list in manifest is something you want to keep small and just for important companies which contributed to the development, since it's also ugly when it's very long
- The contributors list in README can be as long as you want because it's not directly in anyone's view IMO - and I think any "thank you" that we can give people that invest their time in OCA, should be given
Just if people themselves feel their contribution is not worth a lot they can just not add it
100% agree.As a side note, remember that there are plenty of ways to contribute to a module without writing a single line of code.OCA should be generous in this kind of attribution. That will encourage people to contribute more.This should be hardcoded in the guidelines though._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Harald Panten López
CEO
Sygel Technology S.L
+34 637 88 42 41 harald.panten@sygel.es https://www.sygel.es C/ Àlaba 61, 5ª planta, 08005, Barcelona _______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Harald Panten López
CEO
Sygel Technology S.L
+34 637 88 42 41 harald.panten@sygel.es https://www.sygel.es C/ Àlaba 61, 5ª planta, 08005, Barcelona
by Harald Panten Lopez - 09:30 - 15 Jul 2021 -
Re: OCA module contributors and migrations
Hello,I think it should be up to modules authors to decide if a contribution is worth getting mentioned or not as in any open source project. Don't like it? Then fork, but make sure you can do better or go back to your place. Indeed we already see some kind of "contribution squatting". I won't give names here but I have seen people forcing new pointless features into famous modules just to drive attention to their own company. This is very real already... Usually people doing this are not serious people, their trivial work won't be missed.And it didn't stop there, in some project you got noobs artificially inflating their image with non relevant contribs and starting to get their noob employee destroy serious modules... In Brazil so many companies failed their project because this kind of un responsable behaviors from noobs trying to auto promote them as expert at any cost to make a dent in the saas business...If you state rules like any tiny contrib is with a mention, soon enough you'll have contribution trolling exploding, just like during the Hacktober fest when gazillions of people were making pointless PRs to any project just to win a free T-shirt. Now think about getting it's company named along with Tecnativa or CamToCamp...This is sad, but this is the wild world we live in. Instead when module authors decide, then real efforts can be rewarded and notoriety squating may be avoided.Also bare in mind that one can always see the number of commits and lines changed in any git(hub) repo, so it's not like it's invisible either...On Wed, Jul 14, 2021, 6:26 AM Harald Panten Lopez <harald.panten@sygel.es> wrote:I think any migration should be considered as a contribution. As some of you said before, that may encourage more users to contribute.Any migration (even if it's a standard migration) needs an investment of time. On the other hand, when a user starts a migration he/she is "open" to receive suggestions, changes... Any migration is liable to become a headache.I agree that correcting a small typo (for example) wouldn't be enough for being considered as a contributor.Regards.El mié, 14 jul 2021 a las 9:17, Jairo Llopis (<jairo.llopis@tecnativa.com>) escribió:El mar, 13 de jul de 2021 a las 15:37:13 PM, David Beal <david.beal@akretion.com> escribió:A point of view could be that contributors should be someone who can answer any questions about the module in the future.Then it should have the expertise on the topic to do it.That sounds more like a maintainer.El mar, 13 de jul de 2021 a las 15:37:12 PM, Tom Blauwendraat <tom@sunflowerweb.nl> escribió:- The "authors" list in manifest is something you want to keep small and just for important companies which contributed to the development, since it's also ugly when it's very long
- The contributors list in README can be as long as you want because it's not directly in anyone's view IMO - and I think any "thank you" that we can give people that invest their time in OCA, should be given
Just if people themselves feel their contribution is not worth a lot they can just not add it
100% agree.As a side note, remember that there are plenty of ways to contribute to a module without writing a single line of code.OCA should be generous in this kind of attribution. That will encourage people to contribute more.This should be hardcoded in the guidelines though._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Harald Panten López
CEO
Sygel Technology S.L
+34 637 88 42 41 harald.panten@sygel.es https://www.sygel.es C/ Àlaba 61, 5ª planta, 08005, Barcelona _______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by "Raphaël Valyi" <rvalyi@akretion.com> - 07:41 - 14 Jul 2021 -
Re: OCA module contributors and migrations
I think any migration should be considered as a contribution. As some of you said before, that may encourage more users to contribute.Any migration (even if it's a standard migration) needs an investment of time. On the other hand, when a user starts a migration he/she is "open" to receive suggestions, changes... Any migration is liable to become a headache.I agree that correcting a small typo (for example) wouldn't be enough for being considered as a contributor.Regards.El mié, 14 jul 2021 a las 9:17, Jairo Llopis (<jairo.llopis@tecnativa.com>) escribió:El mar, 13 de jul de 2021 a las 15:37:13 PM, David Beal <david.beal@akretion.com> escribió:A point of view could be that contributors should be someone who can answer any questions about the module in the future.Then it should have the expertise on the topic to do it.That sounds more like a maintainer.El mar, 13 de jul de 2021 a las 15:37:12 PM, Tom Blauwendraat <tom@sunflowerweb.nl> escribió:
- The "authors" list in manifest is something you want to keep small and just for important companies which contributed to the development, since it's also ugly when it's very long
- The contributors list in README can be as long as you want because it's not directly in anyone's view IMO - and I think any "thank you" that we can give people that invest their time in OCA, should be given
Just if people themselves feel their contribution is not worth a lot they can just not add it
100% agree.As a side note, remember that there are plenty of ways to contribute to a module without writing a single line of code.OCA should be generous in this kind of attribution. That will encourage people to contribute more.This should be hardcoded in the guidelines though._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
--Harald Panten López
CEO
Sygel Technology S.L
+34 637 88 42 41 harald.panten@sygel.es https://www.sygel.es C/ Àlaba 61, 5ª planta, 08005, Barcelona
by Harald Panten Lopez - 11:25 - 14 Jul 2021
-
