Skip to Content

Contributors

Re: OCA rental solution and rental vertical repository request

Olaf,

I think something has been miscommunicated. Talk to Frederik, but as far as I knew if not approved, it was already way down that track. Better to pick that up than restart. I think the main issue was just resolving a conflict with the existing repository.



On Wed, 25 Nov 2020, 12:47 am Olaf Wagner, <wagner@elegosoft.com> wrote:
Hello everybody,

this year we have been busy implementing a complete rental solution based
on Odoo CE v12 and lots of OCA modules for a German customer. It is already
in production use since July. We explicitly agreed on contributing all the
code to the OCA, but due to COVID-19 restrictions and several personal
complications this work was considerably delayed.

We already asked in March this year for a repository to check-in
all the code directly at OCA, but IIRC there was not much interest back
then. Ben Brich was also involved in the design and implementation of
parts of the code, and Frederik Kramer should know about it, too.

The solution we have has been designed for a German customer business
renting large machines and vehicles, but it should be useful for other
lines of business as well. Considerable efforts have been invested to
make it really useful from the pragmatic point of view of the customer.

There is a short presentation video at Youtube:
--> https://www.youtube.com/watch?v=CzO5NqgJWD0

Currently we've got 31 modules for rental extensions and 3 for shipment
extensions based on a module that was present on Odoo v8:

rental_base/
rental_contract/
rental_contract_insurance/
rental_contract_month/
rental_contract_toll_collect/
rental_forward_shipment_plan/
rental_loan/
rental_menu_crm/
rental_offday/
rental_pricelist/
rental_product_instance/
rental_product_instance_appointment/
rental_product_instance_repair/
rental_product_insurance/
rental_product_pack/
rental_product_set/
rental_product_variant/
rental_purchase_order_type/
rental_quality_control/
rental_repair/
rental_reporting/
rental_routing/
rental_sale/
rental_timeline/
rental_timeline_offday/
rental_timeline_product_instance/
rental_timeline_product_instance_appointment/
rental_timeline_product_variant/
rental_timeline_repair/
rental_timeline_transport/
rental_toll_collect/

shipment_plan/
shipment_plan_rental/
shipment_plan_sale/

Base for the work is the module sale_rental from the sale-workflow
repository; it has been renamed in our code as rental_sale with some
slight modifications in order to avoid conflicts when using code from
both repositories. All other rental modules above are new.

We've synchronized the code to a Github repository now at
https://github.com/elego/rental-vertical/tree/v12 where you can inspect
it. It is still missing some documentation and the test coverage is only
at 73% so there is still room for improvements. We're going to continue
to work on that, but would also like your opinions an comments on
everything.

We're using the v12 branch as internal integration branch there and
could merge from there to an 'official' 12.0 branch now and then.

The structure of everything should be according to the OCA conventions
as far as we know and understand them; some adaptations may of course
be necessary.

Please let us know how to proceed with contributing this code to the
OCA. I think it should be fit at least for an alpha-status in a new
repo.

Greetings from Berlin,

Olaf


-- 
Olaf Wagner -- elego Software Solutions GmbH -- http://www.elegosoft.com 
               Gustav-Meyer-Allee 25 / Gebäude 12, 13355 Berlin, Germany
Geschäftsführer: Olaf Wagner | Sitz: Berlin
Handelregister: Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


by Graeme Gellatly - 07:41 - 24 Nov 2020

Reference

  • OCA rental solution and rental vertical repository request
    Hello everybody,
    
    this year we have been busy implementing a complete rental solution based
    on Odoo CE v12 and lots of OCA modules for a German customer. It is already
    in production use since July. We explicitly agreed on contributing all the
    code to the OCA, but due to COVID-19 restrictions and several personal
    complications this work was considerably delayed.
    
    We already asked in March this year for a repository to check-in
    all the code directly at OCA, but IIRC there was not much interest back
    then. Ben Brich was also involved in the design and implementation of
    parts of the code, and Frederik Kramer should know about it, too.
    
    The solution we have has been designed for a German customer business
    renting large machines and vehicles, but it should be useful for other
    lines of business as well. Considerable efforts have been invested to
    make it really useful from the pragmatic point of view of the customer.
    
    There is a short presentation video at Youtube:
    --> https://www.youtube.com/watch?v=CzO5NqgJWD0
    
    Currently we've got 31 modules for rental extensions and 3 for shipment
    extensions based on a module that was present on Odoo v8:
    
    rental_base/
    rental_contract/
    rental_contract_insurance/
    rental_contract_month/
    rental_contract_toll_collect/
    rental_forward_shipment_plan/
    rental_loan/
    rental_menu_crm/
    rental_offday/
    rental_pricelist/
    rental_product_instance/
    rental_product_instance_appointment/
    rental_product_instance_repair/
    rental_product_insurance/
    rental_product_pack/
    rental_product_set/
    rental_product_variant/
    rental_purchase_order_type/
    rental_quality_control/
    rental_repair/
    rental_reporting/
    rental_routing/
    rental_sale/
    rental_timeline/
    rental_timeline_offday/
    rental_timeline_product_instance/
    rental_timeline_product_instance_appointment/
    rental_timeline_product_variant/
    rental_timeline_repair/
    rental_timeline_transport/
    rental_toll_collect/
    
    shipment_plan/
    shipment_plan_rental/
    shipment_plan_sale/
    
    Base for the work is the module sale_rental from the sale-workflow
    repository; it has been renamed in our code as rental_sale with some
    slight modifications in order to avoid conflicts when using code from
    both repositories. All other rental modules above are new.
    
    We've synchronized the code to a Github repository now at
    https://github.com/elego/rental-vertical/tree/v12 where you can inspect
    it. It is still missing some documentation and the test coverage is only
    at 73% so there is still room for improvements. We're going to continue
    to work on that, but would also like your opinions an comments on
    everything.
    
    We're using the v12 branch as internal integration branch there and
    could merge from there to an 'official' 12.0 branch now and then.
    
    The structure of everything should be according to the OCA conventions
    as far as we know and understand them; some adaptations may of course
    be necessary.
    
    Please let us know how to proceed with contributing this code to the
    OCA. I think it should be fit at least for an alpha-status in a new
    repo.
    
    Greetings from Berlin,
    
    Olaf
    
    -- 
    Olaf Wagner -- elego Software Solutions GmbH -- http://www.elegosoft.com 
                   Gustav-Meyer-Allee 25 / Gebäude 12, 13355 Berlin, Germany
    Geschäftsführer: Olaf Wagner | Sitz: Berlin
    Handelregister: Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
    

    by Olaf Wagner <wagner@elegosoft.com> - 12:46 - 24 Nov 2020