Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: pre-commit changes

Archives

Contributors

Migration 12.0 -> 13.0 and field collision

Translation for Odoo core<=12.0

Re: pre-commit changes

> The idea of the first pre-commit set is to store the automatic changes

Well, I was coming from a place where I'd separate aesthetic changes (automatic or not) vs. functional changes, but thanks for clarifing that.

I'll squash my intermediate commit into the Migration one.

Have a nice day.
by Marco Colombo - 02:10 - 6 Dec 2022

Follow-Ups

  • Re: pre-commit changes
    Daniel, the question is not related to the pre-commit config, but the changes that pre-commit does on your code.

    Regards.
    by Pedro M. Baeza - 04:25 - 9 Dec 2022
  • Re: pre-commit changes
    Actually, pre-commit config updates should be on their own commit, so that they don't contaminate the module history.

    You may want to also create a separate PR cherry-picking that particular commit, that can be fat tracked by maintainers.
    That will avoid the risk of someone else proposing a different commit to update pre-commit config, that will cause you merge conflicts.

    Thanks
    Daniel

    On 06/12/22 13:11, Marco Colombo wrote:
    > The idea of the first pre-commit set is to store the automatic changes

    Well, I was coming from a place where I'd separate aesthetic changes (automatic or not) vs. functional changes, but thanks for clarifing that.

    I'll squash my intermediate commit into the Migration one.

    Have a nice day.

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe


    --
    DANIEL REIS
    MANAGING DIRECTOR

    M: +351 919 991 307
    E: dreis@OpenSourceIntegrators.com
    A: Avenida da República 3000, Estoril Office B, #34

    by Daniel Reis - 10:35 - 9 Dec 2022