Archives
Contributors
Re: Pylint checks to solve or not
Thanks Graeme, Finally the answer is there https://github.com/OCA/pylint-odoo#skip-one-xml-check to escape check in xml test files and https://github.com/OCA/edi/tree/10.0 is now green Bonne journée David BEAL - akretion.com Consultant Odoo Intégration / Développement Le jeu. 9 juil. 2020 à 00:12, Graeme Gellatly <gdgellatly@gmail.com> a écrit : > > Hi, > > My favorite one is the one where black adds a comma at end of a list, collapses it onto a single line then pylint complains about no whitespace on comma. e.g fields.Selection([(.., ..), (.., ..), (.., ..),], and its mandatory. > > So annoying. But Mandatory and Optional mean different things than C and W. Mandatory is collection of pylint errors and warnings. So is optional. They are maintained in separate files so any difference is likely due to changes in those files between the Pull Branch and Destination Branch over time. > > On Thu, Jul 9, 2020 at 3:12 AM David Beal <david.beal@akretion.com> wrote: > > Hi all, > > I have a doubt about pylint checks that have to be solved, mandatory or not ? > > Example with this file > https://travis-ci.org/github/OCA/edi/jobs/705389557 > > I have checked with C prefix with bold form sentence like here > https://travis-ci.org/github/OCA/edi/jobs/705389557#L306 > > I have others with W prefix (probably means warning) > > If I assume only C checks need to be mandatory solved, is it exact ? > > I'm a little surprised that check in PR > https://github.com/OCA/edi/pull/172 > are different from checks in final merge. > > see travis of last commit > https://github.com/OCA/edi/commits/8eb114944a4fcd9fc76b2a53e9078b742f7ee76f > > But I can live with it if you I have an answer in my first question. > > Thanks a lot > > Bonne journée > > > David BEAL - akretion.com > Consultant > Odoo Intégration / Développement > > _______________________________________________ > Mailing-List: https://odoo-community.org/groups/contributors-15 > Post to: mailto:contributors@odoo-community.org > Unsubscribe: https://odoo-community.org/groups?unsubscribe > > _______________________________________________ > Mailing-List: https://odoo-community.org/groups/contributors-15 > Post to: mailto:contributors@odoo-community.org > Unsubscribe: https://odoo-community.org/groups?unsubscribe
by David BEAL - 04:11 - 15 Jul 2020
Reference
-
Pylint checks to solve or not
Hi all, I have a doubt about pylint checks that have to be solved, mandatory or not ? Example with this file https://travis-ci.org/github/OCA/edi/jobs/705389557 I have checked with C prefix with bold form sentence like here https://travis-ci.org/github/OCA/edi/jobs/705389557#L306 I have others with W prefix (probably means warning) If I assume only C checks need to be mandatory solved, is it exact ? I'm a little surprised that check in PR https://github.com/OCA/edi/pull/172 are different from checks in final merge. see travis of last commit https://github.com/OCA/edi/commits/8eb114944a4fcd9fc76b2a53e9078b742f7ee76f But I can live with it if you I have an answer in my first question. Thanks a lot Bonne journée David BEAL - akretion.com Consultant Odoo Intégration / Développement
by David BEAL - 05:10 - 8 Jul 2020