- Mailing Lists
- Contributors
- Re: Reviews
Archives
- By thread 1419
-
By date
- August 2019 59
- September 2019 118
- October 2019 165
- November 2019 97
- December 2019 35
- January 2020 58
- February 2020 204
- March 2020 121
- April 2020 172
- May 2020 50
- June 2020 158
- July 2020 85
- August 2020 94
- September 2020 193
- October 2020 277
- November 2020 100
- December 2020 159
- January 2021 38
- February 2021 87
- March 2021 146
- April 2021 73
- May 2021 90
- June 2021 86
- July 2021 123
- August 2021 50
- September 2021 68
- October 2021 66
- November 2021 74
- December 2021 75
- January 2022 98
- February 2022 77
- March 2022 68
- April 2022 31
- May 2022 59
- June 2022 87
- July 2022 141
- August 2022 38
- September 2022 73
- October 2022 152
- November 2022 39
- December 2022 50
- January 2023 93
- February 2023 49
- March 2023 106
- April 2023 47
- May 2023 69
- June 2023 92
- July 2023 64
- August 2023 103
- September 2023 91
- October 2023 101
- November 2023 94
- December 2023 46
- January 2024 75
- February 2024 79
- March 2024 104
- April 2024 63
- May 2024 40
- June 2024 160
- July 2024 80
- August 2024 70
- September 2024 62
- October 2024 121
- November 2024 117
- December 2024 89
- January 2025 59
- February 2025 104
- March 2025 96
- April 2025 107
- May 2025 52
- June 2025 72
- July 2025 60
- August 2025 81
- September 2025 124
- October 2025 63
- November 2025 22
Contributors
Re: Reviews
Wow, i must say that everyone comes up with much better ideas than I had originally.
Regarding the "smarter bot" ideas: although it's typical for a bunch of programmers to come up with a solution to a problem by throwing more engineering into it, I feel there's something to it, it just needs more crystallization and then a hackathon to make it happen. Maybe a good theme for a team at this year's online code sprint?
I hope more people keep contributing to this thread since I do think it's a big issue. I'm also interested to know how other open source projects are handling this. And perhaps we can look at the "IT projects LLC" repos for inspiration - even though i dont understand their system, it looks pretty happy with all the icons. A "important bugfix" being represented by an ambulance.
A question that popped to my mind yesterday is one for the board - has it ever been considered for OCA to pay people to fulfill maintainer roles within the organisation? Money seems to be something thats available, and the spending of money on OpenUpgrade has been a great things throughout the last years also.
Thanks all
Regarding the "smarter bot" ideas: although it's typical for a bunch of programmers to come up with a solution to a problem by throwing more engineering into it, I feel there's something to it, it just needs more crystallization and then a hackathon to make it happen. Maybe a good theme for a team at this year's online code sprint?
I hope more people keep contributing to this thread since I do think it's a big issue. I'm also interested to know how other open source projects are handling this. And perhaps we can look at the "IT projects LLC" repos for inspiration - even though i dont understand their system, it looks pretty happy with all the icons. A "important bugfix" being represented by an ambulance.
A question that popped to my mind yesterday is one for the board - has it ever been considered for OCA to pay people to fulfill maintainer roles within the organisation? Money seems to be something thats available, and the spending of money on OpenUpgrade has been a great things throughout the last years also.
Thanks all
Sep 17, 2021 09:02:07 Yann Papouin <ypa@decgroupe.com>:
+1 for the bw/fwport bot
- It would be nice to have a new convention to tag a PR with a label like "Review it in 30 seconds" [R30] when it is a basic/simple/quick fix add/fwd that does not require you to soak up the functioning.- It would be nice too that a bot automatically tag an issue/PR with a github label based on the issue/PR name or simply the target branch name : eg: [12.0] ->![]()
--
Yann PAPOUIN, Ingénieur R&D | DEC
Le ven. 17 sept. 2021 à 08:52, Jairo Llopis <jairo.llopis@tecnativa.com> a écrit :
I should add that repos using the template (all AFAIK) can upgrade to the latest version and benefit from https://github.com/OCA/oca-addons-repo-template/pull/63. A bot will warn and close stale PRs/issues.
El jue, 16 de sep de 2021 a las 12:51:48 PM, Sylvain LE GAL <sylvain.legal@grap.coop> escribió:
That's true ! One of the origins is the fast release rate of Odoo, which requires continuous migration of modules that, for many, do not change.
Unfortunately, that situation will not change. Odoo policy seems to be : "a year = a release".
Yep. They do it because they can handle it. The question is: why we can't?
There are many reasons, but the one that I find most important and easiest to fix is that we need a bw/fwport bot.
That will make maintenance pleasing, so we'll have more maintainers._______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe
by Tom Blauwendraat - 09:40 - 17 Sep 2021
Reference
-
Reviews
Hi all, For years, OCA has a big problem with unmerged PR's. Also, even if there are 2 reviews then PSC's generally don't respond to merge requests. The answer has always been "let's review more" or "Let's use gitaggregator and so we can use unmerged PR's". But why don't we try something more radical: - Let's write a script to assign "maintainer" role for all modules to the person who committed the oldest/original version of it - If maintainer does not respond to a ping longer than 1 month he loses the maintainer role, which then changes to the default maintainer that is set for the full repo. - Let's require only 1 positive review from now on. After that the maintainer can merge. --> I don't think that having 2 reviewers is always necessary and it also does not prevent bugs from being merged - this happens anyway. I used to have high trust of merged OCA modules but after seeing some quite ugly bugs and incomplete work being merged I am starting to think that maybe the quality of the unmerged stuff is not that bad as compared to what is actually merged. The maintainer can prevent really bad changes from entering, by just closing the PR. Tom
by Tom Blauwendraat - 01:51 - 16 Sep 2021