Skip to Content

Contributors

Re: Sorry, i'm not familiar with git

Hi Martin I made a small research and I'd like to make a try but at the same time I always doubt about the action I'm planning to do on git. 
For example in this case I have read in this article https://www.educative.io/answers/how-to-change-a-git-commit-message-after-a-push that I could use:

git commit --amend -m "New message" 
git push --force-with-lease repository-name branch-name

but I am not sure about the 'force' or --force-with-lease which seems a less intrusive option. What I don't understand is, if --force 'which will destroy any changes someone else has pushed to the branch' as I read in the article, and --force-with-lease will "abort if there was an upstream change to the repository", is for me enough to fetch the origin before the amend/push to make a safe amend (I am not even sure this sentence makes sense eheh) or maybe it is an alternative way that I don't know? 

Thanks,
Francesco 

 

Il giorno gio 19 gen 2023 alle ore 09:27 Francesco Ballerini <francescobl.lavoro@gmail.com> ha scritto:
Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

Thank you,
Francesco

Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
On 19/01/2023 00:57, Francesco Ballerini wrote:
Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

Hello,

This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

Martin

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe


by Francesco Ballerini - 06:56 - 19 Jan 2023

Reference

  • Sorry, i'm not familiar with git
    Hi everyone, I am discovering git/github/Pull Requests and I am receiving this error. 

    Basically I wanted to ask how can I fix this, but most importantly I want to excuse because I think that I forced pushed while trying to fix it. 

    Not sure if force pushing can really cause problems in protected branches, but I have read it's a really bad practice. 

    I suddenly panicked like I never did, of course, and immediately cancelled PR and made it new. But the error is still here. Not sure about the error, what could I do in this situation? 


    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'
    Thanks in advance,
    Francesco Ballerini

    by Francesco Ballerini - 12:56 - 19 Jan 2023