Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: The future of oca/bank-payment

Archives

Contributors

Re: The future of oca/bank-payment

Re: The future of oca/bank-payment

Re: The future of oca/bank-payment

Bravo, Enric, thanks for these words that I totally shared.

Stéphane, Friday 18th was the deadline, the limit date, giving by Virginie to heard a decision on Alexis side if he wants to accept my offering of converging the good things of his proposal (like the XML export refactoring) into the current one, and put in pause (which is not the same as to reject) the switch to that fields till 19, while we get more information from Odoo what are their intentions with them, or directly see if Odoo expands their usage, but he was pretty clear that he doesn't want to converge in any case in 18 in this message, and proposing something impossible: once you split into 2, join both forks again is not going to happen. And less with a person that has proved now that has no will of wanting to converge. Or the rest follows whatever he wants to propose, or no more effort on his part. So, what I did is to follow our path. No need to wait more because nothing will change waiting till today.

I reiterate again my will of putting more of my time extracting the improvements on the XML export code if you at least accept to resign on some things for 18.0 while we continue investigating, but if not, I think this is a definitive schism with a lot of consequences.

Regards.
by Pedro M. Baeza - 07:16 - 18 Apr 2025

Reference

  • The future of oca/bank-payment
    Hi everyone,

    The oca/bank-payment repository has the essential modules to prepare and generate SEPA (and more) payment orders for credit transfer and direct debit.

    Today, there are important decisions to make about the future of this module.

    18 months ago, Alexis de Lattre, (one of) the original authors of these modules, started a huge effort to modernize these modules and improve their overall quality.
    He explained his approach in this PR 1174 for 16.0  [1]. 
    Naturally, that PR was not merged because it came too late in the 16.0 release cycle. 

    Now Alexis continues this effort with a series of 18.0 pull requests, with the important addition that he proposes to replace the Payment Mode object by the now native object from Odoo. 

    In Odoo v18, Odoo SA introduced new "Payment mode" M2O fields in the "account" module (cf this commit [6]):
    - on res.partner : one property field "Customer Payment Method" and one property field "Supplier Payment Method"
    - on invoices (account.move) : one field "Payment Method", copied from res.partner and that can be modified
    Up to Odoo v17, these "Payment mode" fields were not native ; they were added by the OCA module account_payment_partner from OCA/bank-payment.
    These new native "Payment mode" fields use the model account.payment.method.line (which was introduced in v15).

    Migrating to use these native fields makes a lot of sense to align with Odoo to avoid duplication of fields and logic.

    For more context, There was some discussion in the 16.0 PR [1], the 18.0 migration issue [4], as well as [5].

    I personally very much welcome this effort as I think the quality of Alexis' work is excellent (as usual), and this will create a solid foundation for the future.
    Indeed, over the many years of history of these modules, the only significant refactoring was Pedro's important work to adapt them to use Account Payment, and these modules start to show their great age.

    Alexis' work can be tested on runboat PR 1406 for direct debit [2] and PR 1405 for credit transfer [3]. From the preliminary tests we have done at Acsone it works fine.

    Of course, such work is not a traditional migration, and is difficult to review due to the importance of the changes. This will also create some additional migration work for maintainers of modules that depend on it (for instance the migration from Payment Mode to native Payment Methods will require some effort, although not difficult).

    On the other hand, reaching the same result by incremental improvements is going to be impossible, because as soon as a module is merged it starts to be extended, and some evolutions will not be possible in a backward-compatible way.

    So Akretion and Acsone propose to add migration scripts, and merge Alexis' work in 18.0 and rapidly iterate from there to review and add possible features that would have been missed in the transition. At Acsone we plan to put significant effort on this repo in the coming 3-4 months.

    Would there be agreement on such an approach?

    Best regards,

    -Stéphane

    by Stéphane Bidoul - 11:45 - 26 Mar 2025