Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Re: Want tax move line with zero balance, possible? (odoo 13)

Archives

Contributors

Re: Want tax move line with zero balance, possible? (odoo 13)

Re: Want tax move line with zero balance, possible? (odoo 13)

Re: Want tax move line with zero balance, possible? (odoo 13)

I understand and share Kitti needs. For me it would be better to have this line as aml. I understand that normally you don't need aml of 0. But on odo an aml is not just an aml, is an invoice line / tax line somehow.
If I understand correctly what Pedro suggest, that helps on financial reports. Or there is some generic method to get tax amounts and tax base amounts from aml's?
In our case, we need this information also in two cases:
* to build txt files related to invoices
* to build the xml for electronic invoice

Actually we get the amounts from aml for any tax not zero but then we need to get the base amounts "manually" for zero taxes.
For me it would be much clearer and easier if we just have an aml of 0 for zero taxes also. But I've lose this fight two many times :p
Actually we would need this line not only if the tax rate is 0, but also if the computed tax is zero (for example a line of 0,01 with VAT 21%, the rounded vat amount is zero and no line is created)

Also oidoo is "simulating" this zero lines on the new tax widget, I haven't analyze it yet, but I believe that code would be easier if an aml of zero would be there



Ing. Juan José Scarafía

(+54 9 341) 3 278039

twitter: @jjscarafia

github: @jjscarafia



On Wed, Jun 17, 2020 at 1:52 PM Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com> wrote:
The field tax_line_ids in account.move.line is filled with the 0-tax ID for the journal item that represents the base amount for the tax.


Regards.

_______________________________________________
Mailing-List: https://odoo-community.org/groups/contributors-15
Post to: mailto:contributors@odoo-community.org
Unsubscribe: https://odoo-community.org/groups?unsubscribe

by Juan José Scarafía - 07:35 - 17 Jun 2020

Reference

  • Want tax move line with zero balance, possible? (odoo 13)
    Dear community,

    With Tax Exemption we need to set tax with zero percent. On invoice line, use will need to choose this Tax. And expect that it will also declared on tax report.

    Normally, as I see in this core code, Odoo just don't create move line if tax amount is zero. This oppose our need.

    def _recompute_tax_lines(self, recompute_tax_base_amount=False):
                .......
                # Don't create tax lines with zero balance.
                if self.currency_id.is_zero(taxes_map_entry['balance']) and self.currency_id.is_zero(taxes_map_entry['amount_currency']):
                    taxes_map_entry['grouping_dict'] = False

    Any OCA module that do by pass this? Does this make sense to you if I will create one, or there is better way ??

    Many thanks,
    Kitti

    by Kitti Upariphutthiphong - 05:55 - 17 Jun 2020

    10 replies 10 replies

    • Re: Want tax move line with zero balance, possible? (odoo 13)
      Some more bugs related to the approach of not generating the zero aml


      Ing. Juan José Scarafía

      (+54 9 341) 3 278039

      twitter: @jjscarafia

      github: @jjscarafia



      On Thu, Jun 18, 2020 at 5:02 PM Kevin McMenamin <Kevin.McMenamin@solnet.co.nz> wrote:

      IMO the standard Odoo tax report is too limited for general use. NZ has probably the most simple tax system in the world but we still needed to write our own tax report. Prior to V13, we used the GL control accounts as the master source of data, but identified any invoice lines that had no tax code so the user could check. We also identify any pre-dated transactions to catch if a user has entered a tax entry for a tax period that is already completed. This is on my list to relook at for V13.

       

       

       

      From: Kitti Upariphutthiphong <kittiu@ecosoft.co.th>
      Sent: Friday, 19 June 2020 1:22 AM
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      Hi Pedro, Juan and Luc,

       

      Thanks a lot for sharing your thoughts. In our localization, we have made the decision to make the tax report out of account.move.line directly. That's part of my difficulties.

       

      I think I understand, may be not on ES or BE localization thoroughly, but the general concept of Odoo's Tax Report.

       

      Odoo Tax Report is quite the summarized report, which is not quite usable for us, I must say. Our tax submission requires more detailed information (frankly quite old fashioned paper based tax report).

       

      So, currently, without zero tax amount move line, we will require rewriting the tax report, and it will become a lot less straightforward than before. This point I share and agree with Juan points.

       

      Thanks a lot for what you guys are sharing, I do understand more. I will think more how to live without it.

       

      Thank you!

      Kitti

       

      On Thu, Jun 18, 2020 at 7:27 PM Juan José Scarafía (ADHOC) <scarafia.juanjose@gmail.com> wrote:

      I agree that they are not needed and there is a work around to work with them, but IMHO, as there is already a tax_base_amount stored field on aml, it would be much easier to get taxes and base amounts just filtering aml with "tax_line_id", and on that aml you already have the balance and the tax amount. That is already in odoo, the only problem is for zero taxes.

       

      IMHO, with the current approach:

      * it's litle ugly how "_compute_invoice_taxes_by_group" simulate the zero taxes

      * more code needed for getting tax amounts on electronic invoice / tax declaration

      * more code needed on the "tax engine"

      You can't analyse directly any odoo model to get this info, is not visual. Just having those lines would make much easier to get visual information about the taxes from everywhere (on the invoice itself, checking the aml on journal items, menus, etc).

       

      But yes, I agree it is not needed, I just believe it would make thing much easier and nicer. But still, is an odoo decision, I wouldn't make any module to change that behaviour .

      BR

       

       

       

       

      Ing. Juan José Scarafía

      (+54 9 341) 3 278039

      twitter: @jjscarafia

      github: @jjscarafia

       

       

      On Wed, Jun 17, 2020 at 3:07 PM <luc.demeyer@noviat.com> wrote:

      We also have zero tax lines in Belgium and no need for aml with debit/credit 0.

      I support Pedro here, with correct reports you solve the issue.

      Cf. https://github.com/Noviat/noviat-apps/tree/13.0/l10n_be_coa_multilang

       

      From: Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com>
      Sent: Wednesday, 17 June 2020 19:47
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      I think the need of that aml with 0 is because the tax engine / exporter is not considering the amls for the base on the said field. We are doing that way on our tax engine for Spanish legislation without problem:

       

       

      The overall logic is:

       

      - There are amls with tax_line_id field with that tax: the tax fee.

      - There are amls with tax_ids field with that tax: the tax base.

       

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      Attention: This email may contain information intended for the sole use of the original recipient. Please respect this when sharing or disclosing this email's contents with any third party. If you believe you have received this email in error, please delete it and notify the sender or postmaster@solnetsolutions.co.nz as soon as possible. The content of this email does not necessarily reflect the views of Solnet Solutions Ltd.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Juan José Scarafía - 05:51 - 17 Jul 2020
    • RE: Want tax move line with zero balance, possible? (odoo 13)

      IMO the standard Odoo tax report is too limited for general use. NZ has probably the most simple tax system in the world but we still needed to write our own tax report. Prior to V13, we used the GL control accounts as the master source of data, but identified any invoice lines that had no tax code so the user could check. We also identify any pre-dated transactions to catch if a user has entered a tax entry for a tax period that is already completed. This is on my list to relook at for V13.

       

       

       

      From: Kitti Upariphutthiphong <kittiu@ecosoft.co.th>
      Sent: Friday, 19 June 2020 1:22 AM
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      Hi Pedro, Juan and Luc,

       

      Thanks a lot for sharing your thoughts. In our localization, we have made the decision to make the tax report out of account.move.line directly. That's part of my difficulties.

       

      I think I understand, may be not on ES or BE localization thoroughly, but the general concept of Odoo's Tax Report.

       

      Odoo Tax Report is quite the summarized report, which is not quite usable for us, I must say. Our tax submission requires more detailed information (frankly quite old fashioned paper based tax report).

       

      So, currently, without zero tax amount move line, we will require rewriting the tax report, and it will become a lot less straightforward than before. This point I share and agree with Juan points.

       

      Thanks a lot for what you guys are sharing, I do understand more. I will think more how to live without it.

       

      Thank you!

      Kitti

       

      On Thu, Jun 18, 2020 at 7:27 PM Juan José Scarafía (ADHOC) <scarafia.juanjose@gmail.com> wrote:

      I agree that they are not needed and there is a work around to work with them, but IMHO, as there is already a tax_base_amount stored field on aml, it would be much easier to get taxes and base amounts just filtering aml with "tax_line_id", and on that aml you already have the balance and the tax amount. That is already in odoo, the only problem is for zero taxes.

       

      IMHO, with the current approach:

      * it's litle ugly how "_compute_invoice_taxes_by_group" simulate the zero taxes

      * more code needed for getting tax amounts on electronic invoice / tax declaration

      * more code needed on the "tax engine"

      You can't analyse directly any odoo model to get this info, is not visual. Just having those lines would make much easier to get visual information about the taxes from everywhere (on the invoice itself, checking the aml on journal items, menus, etc).

       

      But yes, I agree it is not needed, I just believe it would make thing much easier and nicer. But still, is an odoo decision, I wouldn't make any module to change that behaviour .

      BR

       

       

       

       

      Ing. Juan José Scarafía

      (+54 9 341) 3 278039

      twitter: @jjscarafia

      github: @jjscarafia

       

       

      On Wed, Jun 17, 2020 at 3:07 PM <luc.demeyer@noviat.com> wrote:

      We also have zero tax lines in Belgium and no need for aml with debit/credit 0.

      I support Pedro here, with correct reports you solve the issue.

      Cf. https://github.com/Noviat/noviat-apps/tree/13.0/l10n_be_coa_multilang

       

      From: Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com>
      Sent: Wednesday, 17 June 2020 19:47
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      I think the need of that aml with 0 is because the tax engine / exporter is not considering the amls for the base on the said field. We are doing that way on our tax engine for Spanish legislation without problem:

       

       

      The overall logic is:

       

      - There are amls with tax_line_id field with that tax: the tax fee.

      - There are amls with tax_ids field with that tax: the tax base.

       

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      Attention: This email may contain information intended for the sole use of the original recipient. Please respect this when sharing or disclosing this email's contents with any third party. If you believe you have received this email in error, please delete it and notify the sender or postmaster@solnetsolutions.co.nz as soon as possible. The content of this email does not necessarily reflect the views of Solnet Solutions Ltd.
      by Kevin McMenamin - 10:00 - 18 Jun 2020
    • Re: Want tax move line with zero balance, possible? (odoo 13)
      Hi Pedro, Juan and Luc,

      Thanks a lot for sharing your thoughts. In our localization, we have made the decision to make the tax report out of account.move.line directly. That's part of my difficulties.

      I think I understand, may be not on ES or BE localization thoroughly, but the general concept of Odoo's Tax Report.

      Odoo Tax Report is quite the summarized report, which is not quite usable for us, I must say. Our tax submission requires more detailed information (frankly quite old fashioned paper based tax report).

      So, currently, without zero tax amount move line, we will require rewriting the tax report, and it will become a lot less straightforward than before. This point I share and agree with Juan points.

      Thanks a lot for what you guys are sharing, I do understand more. I will think more how to live without it.

      Thank you!
      Kitti

      On Thu, Jun 18, 2020 at 7:27 PM Juan José Scarafía (ADHOC) <scarafia.juanjose@gmail.com> wrote:
      I agree that they are not needed and there is a work around to work with them, but IMHO, as there is already a tax_base_amount stored field on aml, it would be much easier to get taxes and base amounts just filtering aml with "tax_line_id", and on that aml you already have the balance and the tax amount. That is already in odoo, the only problem is for zero taxes.

      IMHO, with the current approach:
      * it's litle ugly how "_compute_invoice_taxes_by_group" simulate the zero taxes
      * more code needed for getting tax amounts on electronic invoice / tax declaration
      * more code needed on the "tax engine"
      You can't analyse directly any odoo model to get this info, is not visual. Just having those lines would make much easier to get visual information about the taxes from everywhere (on the invoice itself, checking the aml on journal items, menus, etc).

      But yes, I agree it is not needed, I just believe it would make thing much easier and nicer. But still, is an odoo decision, I wouldn't make any module to change that behaviour .
      BR




      Ing. Juan José Scarafía

      (+54 9 341) 3 278039

      twitter: @jjscarafia

      github: @jjscarafia



      On Wed, Jun 17, 2020 at 3:07 PM <luc.demeyer@noviat.com> wrote:

      We also have zero tax lines in Belgium and no need for aml with debit/credit 0.

      I support Pedro here, with correct reports you solve the issue.

      Cf. https://github.com/Noviat/noviat-apps/tree/13.0/l10n_be_coa_multilang

       

      From: Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com>
      Sent: Wednesday, 17 June 2020 19:47
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      I think the need of that aml with 0 is because the tax engine / exporter is not considering the amls for the base on the said field. We are doing that way on our tax engine for Spanish legislation without problem:

       

       

      The overall logic is:

       

      - There are amls with tax_line_id field with that tax: the tax fee.

      - There are amls with tax_ids field with that tax: the tax base.

       

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Kitti Upariphutthiphong - 03:21 - 18 Jun 2020
    • Re: Want tax move line with zero balance, possible? (odoo 13)
      I agree that they are not needed and there is a work around to work with them, but IMHO, as there is already a tax_base_amount stored field on aml, it would be much easier to get taxes and base amounts just filtering aml with "tax_line_id", and on that aml you already have the balance and the tax amount. That is already in odoo, the only problem is for zero taxes.

      IMHO, with the current approach:
      * it's litle ugly how "_compute_invoice_taxes_by_group" simulate the zero taxes
      * more code needed for getting tax amounts on electronic invoice / tax declaration
      * more code needed on the "tax engine"
      You can't analyse directly any odoo model to get this info, is not visual. Just having those lines would make much easier to get visual information about the taxes from everywhere (on the invoice itself, checking the aml on journal items, menus, etc).

      But yes, I agree it is not needed, I just believe it would make thing much easier and nicer. But still, is an odoo decision, I wouldn't make any module to change that behaviour .
      BR




      Ing. Juan José Scarafía

      (+54 9 341) 3 278039

      twitter: @jjscarafia

      github: @jjscarafia



      On Wed, Jun 17, 2020 at 3:07 PM <luc.demeyer@noviat.com> wrote:

      We also have zero tax lines in Belgium and no need for aml with debit/credit 0.

      I support Pedro here, with correct reports you solve the issue.

      Cf. https://github.com/Noviat/noviat-apps/tree/13.0/l10n_be_coa_multilang

       

      From: Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com>
      Sent: Wednesday, 17 June 2020 19:47
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      I think the need of that aml with 0 is because the tax engine / exporter is not considering the amls for the base on the said field. We are doing that way on our tax engine for Spanish legislation without problem:

       

       

      The overall logic is:

       

      - There are amls with tax_line_id field with that tax: the tax fee.

      - There are amls with tax_ids field with that tax: the tax base.

       

      Regards.

      _______________________________________________
      Mailing-List: https://odoo-community.org/groups/contributors-15
      Post to: mailto:contributors@odoo-community.org
      Unsubscribe: https://odoo-community.org/groups?unsubscribe

      by Juan José Scarafía - 02:26 - 18 Jun 2020
    • RE: Want tax move line with zero balance, possible? (odoo 13)

      We also have zero tax lines in Belgium and no need for aml with debit/credit 0.

      I support Pedro here, with correct reports you solve the issue.

      Cf. https://github.com/Noviat/noviat-apps/tree/13.0/l10n_be_coa_multilang

       

      From: Pedro M. Baeza (Tecnativa) <pedro.baeza@tecnativa.com>
      Sent: Wednesday, 17 June 2020 19:47
      To: Contributors <contributors@odoo-community.org>
      Subject: Re: Want tax move line with zero balance, possible? (odoo 13)

       

      I think the need of that aml with 0 is because the tax engine / exporter is not considering the amls for the base on the said field. We are doing that way on our tax engine for Spanish legislation without problem:

       

       

      The overall logic is:

       

      - There are amls with tax_line_id field with that tax: the tax fee.

      - There are amls with tax_ids field with that tax: the tax base.

       

      Regards.

      by Luc De Meyer. - 08:06 - 17 Jun 2020