Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Sorry, i'm not familiar with git

Archives

Contributors

Multi-company > one default bank account

Weblate - use po file download/upload - revisions

Sorry, i'm not familiar with git

Hi everyone, I am discovering git/github/Pull Requests and I am receiving this error. 

Basically I wanted to ask how can I fix this, but most importantly I want to excuse because I think that I forced pushed while trying to fix it. 

Not sure if force pushing can really cause problems in protected branches, but I have read it's a really bad practice. 

I suddenly panicked like I never did, of course, and immediately cancelled PR and made it new. But the error is still here. Not sure about the error, what could I do in this situation? 


Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'
Thanks in advance,
Francesco Ballerini
by Francesco Ballerini - 12:56 - 19 Jan 2023

Follow-Ups

  • Re: Sorry, i'm not familiar with git
    Thanks for the feedback Holger, is good to have some reliable indications on the right documentation to follow. For now i'll just save the link but this should go in my to-do list : )
    I just managed to solve the issue on the commit name, thanks everyone for the patience and advices.

    Il giorno gio 19 gen 2023 alle ore 23:47 Holger Brunn <notifications@odoo-community.org> ha scritto:
    > Hi Martin I made a small research and I'd like to make a try but at the same


> time I always doubt about the action I'm planning to do on git.  For


> example in this case I have read in this article

if you keep reading recipes about isolated issues you'll always doubt what 
you're doing. I recommend reading
https://git-scm.com/book/en/v2
(skip 4 and stop after 9)
and then you'll be confident on all git related actions



-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Francesco Ballerini - 12:20 - 20 Jan 2023
  • Re: Sorry, i'm not familiar with git 
    > Hi Martin I made a small research and I'd like to make a try but at the same

> time I always doubt about the action I'm planning to do on git.  For

> example in this case I have read in this article

if you keep reading recipes about isolated issues you'll always doubt what 
you're doing. I recommend reading
https://git-scm.com/book/en/v2
(skip 4 and stop after 9)
and then you'll be confident on all git related actions


-- 
Your partner for the hard Odoo problems
https://hunki-enterprises.com
    by Holger Brunn - 11:46 - 19 Jan 2023

    1 attachments 1 attachments

    signature.asc
  • Re: Sorry, i'm not familiar with git

    Hi Franscesco,

    In this case, you seams to force-push on a branch that you own, and no body else is working on it. So, nobody will get trouble with you force push and you don't risk to destroy works of other as you are the only one working on your branch.

    It seams to be a good practice to use '--force-with-lease' when a force push is needed. If it fails it means you have to look closer of what your doing and why the push did work by looking at the history of the local and the remote branch. Common failing cases are that you try to push on the wrong remote branch or your going to delete commits from others. For the last case you need to pull and rebase and then push again.

    As you said, you're not familiar with the basic concept of git. When using such a tool, its very recommended to understand some concept so that it reveals to you the magic behind and you will fly from your own. There are lots of tutorials on the web, choose the one that you prefer. It will saves you lots of time. :)

    See you on PR's one the OCA repository. :)

    Regards,

    Le 19 janvier 2023 18:57:25 GMT+01:00, Francesco Ballerini <notifications@odoo-community.org> a écrit :
    Hi Martin I made a small research and I'd like to make a try but at the same time I always doubt about the action I'm planning to do on git. 
    For example in this case I have read in this article https://www.educative.io/answers/how-to-change-a-git-commit-message-after-a-push that I could use:

    git commit --amend -m "New message" 
    git push --force-with-lease repository-name branch-name

    but I am not sure about the 'force' or --force-with-lease which seems a less intrusive option. What I don't understand is, if --force 'which will destroy any changes someone else has pushed to the branch' as I read in the article, and --force-with-lease will "abort if there was an upstream change to the repository", is for me enough to fetch the origin before the amend/push to make a safe amend (I am not even sure this sentence makes sense eheh) or maybe it is an alternative way that I don't know? 

    Thanks,
    Francesco 

     

    Il giorno gio 19 gen 2023 alle ore 09:27 Francesco Ballerini <francescobl.lavoro@gmail.com> ha scritto:
    Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

    Thank you,
    Francesco

    Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
    On 19/01/2023 00:57, Francesco Ballerini wrote:
    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

    Hello,

    This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
    But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

    Martin

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    --
    Rémy Taymans
    Coop IT Easy
    https://coopiteasy.be
    by Rémy Taymans - 09:01 - 19 Jan 2023
  • Re: Sorry, i'm not familiar with git
    Hi Martin I made a small research and I'd like to make a try but at the same time I always doubt about the action I'm planning to do on git. 
    For example in this case I have read in this article https://www.educative.io/answers/how-to-change-a-git-commit-message-after-a-push that I could use:

    git commit --amend -m "New message" 
    git push --force-with-lease repository-name branch-name

    but I am not sure about the 'force' or --force-with-lease which seems a less intrusive option. What I don't understand is, if --force 'which will destroy any changes someone else has pushed to the branch' as I read in the article, and --force-with-lease will "abort if there was an upstream change to the repository", is for me enough to fetch the origin before the amend/push to make a safe amend (I am not even sure this sentence makes sense eheh) or maybe it is an alternative way that I don't know? 

    Thanks,
    Francesco 

     

    Il giorno gio 19 gen 2023 alle ore 09:27 Francesco Ballerini <francescobl.lavoro@gmail.com> ha scritto:
    Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

    Thank you,
    Francesco

    Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
    On 19/01/2023 00:57, Francesco Ballerini wrote:
    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

    Hello,

    This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
    But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

    Martin

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Francesco Ballerini - 06:56 - 19 Jan 2023
  • Re: Sorry, i'm not familiar with git
    Thanks, I would appreciate that a lot, if it's easy to solve for you. I was a little bit tired yesterday and don't wanna make even more trouble eheh ... : )

    Thank you,
    Francesco

    Il giorno gio 19 gen 2023 alle ore 08:32 Martin Trigaux (mat) <notifications@odoo-community.org> ha scritto:
    On 19/01/2023 00:57, Francesco Ballerini wrote:
    Invalid title for commit: ' [FIX] product: add explicit copy arg to property_product_pricelist'

    Hello,

    This one is because you have a space in the beginning of the commit message, " [FIX]" instead of "[FIX]" ;-)
    But don't worry about it if you are not sure how to amend your commit, we can handle it for you if needed.

    Martin

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Francesco Ballerini - 09:30 - 19 Jan 2023