Skip to Content
  2. Mailing Lists
  3. Contributors
  4. Travis set up on 13.0

Archives

Contributors

Re: Odoo Developers Telegram Group

OCA webinars and e-learning ?

Travis set up on 13.0

Hi all,

I’m porting a trivial module to the 13.0 version and I found some “problems” with Travis.

One is this:

 

 

Another is multiple white spaces between var and value.

 

I think that the proposed correction decreases readability.

 

This feature can be set up in other way, ie to accept multi rows or white spaces?

 

Stefano Consolaro

mymage.it

 

by Stefano Consolaro - 07:01 - 5 Apr 2020

1 attachments 1 attachments

image001.png

Follow-Ups

  • Re: Travis set up on 13.0
    We use black (The Uncompromising Code Formatter) to not think too much about format and not have to make special rules.

    Readability does count. IMO the code you show seems still readable. And if you add some other dependencies, it will change the list to multiple lines.

    To note, when it's really needed, you can add comments to wrap the code when you don't want to be auto corrected. (IIRC # fmt: off and # fmt: on)

    To read more about black go there: https://github.com/psf/black

    Cheers,
    Yannick Vaucher
    Business Solutions Architect

    Camptocamp SA
    PSE A, CH-1015 Lausanne
    Phone: +41 21 619 10 30
    Office: +41 21 619 10 10


    On Sun, 5 Apr 2020 at 20:27, Stefano Consolaro <stefano.consolaro@mymage.it> wrote:
    Ups, lost image.
    MY CODE:
    "depends": [
                      "hr",
                      "mgmtsystem_nonconformity"
                     ],
    TRAVIS
    "depends": ["hr", "mgmtsystem_nonconformity"],


    Da: "Stefano Consolaro" stefano.consolaro@mymage.it
    Cc:
    Data: Sun, 05 Apr 2020 17:02:13 -0000
    Oggetto: Travis set up on 13.0

    Hi all,

    I’m porting a trivial module to the 13.0 version and I found some “problems” with Travis.

    One is this:

     

     

    Another is multiple white spaces between var and value.

     

    I think that the proposed correction decreases readability.

     

    This feature can be set up in other way, ie to accept multi rows or white spaces?

     

    Stefano Consolaro

    mymage.it

     

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe



    Stefano Consolaro

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe

    by Yannick Payot - 01:50 - 6 Apr 2020
  • Re: Travis set up on 13.0
    Ups, lost image.
    MY CODE:
    "depends": [
                      "hr",
                      "mgmtsystem_nonconformity"
                     ],
    TRAVIS
    "depends": ["hr", "mgmtsystem_nonconformity"],


    Da: "Stefano Consolaro" stefano.consolaro@mymage.it
    A: "Contributors" contributors@odoo-community.org
    Cc:
    Data: Sun, 05 Apr 2020 17:02:13 -0000
    Oggetto: Travis set up on 13.0

    Hi all,

    I’m porting a trivial module to the 13.0 version and I found some “problems” with Travis.

    One is this:

     

     

    Another is multiple white spaces between var and value.

     

    I think that the proposed correction decreases readability.

     

    This feature can be set up in other way, ie to accept multi rows or white spaces?

     

    Stefano Consolaro

    mymage.it

     

    _______________________________________________
    Mailing-List: https://odoo-community.org/groups/contributors-15
    Post to: mailto:contributors@odoo-community.org
    Unsubscribe: https://odoo-community.org/groups?unsubscribe



    Stefano Consolaro
    www.mymage.it
    by Stefano Consolaro - 08:26 - 5 Apr 2020